Skip to content

JSON3Ext: Deprecate Dagger.render_logs for :chrome_trace #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpsamaroo merged 4 commits into from
Jun 5, 2025
Merged

JSON3Ext: Deprecate Dagger.render_logs for :chrome_trace #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5bdac2
Input:
google-labs-jules[bot] Jun 5, 2025
bf5cc6d
Input:
google-labs-jules[bot] Jun 5, 2025
a6a225f
Clean up temporary files and revert Project.toml
google-labs-jules[bot] Jun 5, 2025
7594712
Merge branch 'master' into jules/deprecate-render-logs-chrome-trace
jpsamaroo Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/src/logging-visualization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ Built-in `IO` support exists for:
Built-in rendering support exists for:
- `render_logs(logs, :graphviz)` to generate a graph diagram of executed tasks and their dependencies (requires `GraphViz.jl` to be loaded)
- `render_logs(logs, :plots_gantt)` to generate a Gantt chart of task execution across all processors (requires `Plots.jl` and `DataFrames.jl` to be loaded)
- `render_logs(logs, :chrome_trace)` to generate a `String` with chrome-trace formatted task execution timeline

The latter (`MultiEventLog`) allows for continuously rendering logs as they're
generated, permitting real-time visualization of Dagger's operations. This
Expand Down
1 change: 1 addition & 0 deletions ext/JSON3Ext.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ function logs_to_chrome_trace(logs::Dict)
end

function Dagger.render_logs(logs::Dict, ::Val{:chrome_trace})
@warn "Dagger.render_logs(logs, :chrome_trace) is deprecated, use Dagger.show_logs(io, logs, :chrome_trace) instead." maxlog=1
return JSON3.write(logs_to_chrome_trace(logs))
end

Expand Down