-
-
Notifications
You must be signed in to change notification settings - Fork 78
stencils: Add tests and documentation #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new test file `test/stencil.jl` with tests for basic stencil operations, boundary conditions, multiple expressions, and multiple DArrays. - Updated `test/runtests.jl` to include the new stencil tests. - Improved the documentation in `docs/src/stencils.jl` with clearer explanations and more examples. - Corrected DArray constructor calls in tests and documentation to use `zeros(Blocks(...), ...)` instead of `Dagger.DArray(zeros(...), ...)`. - Removed `using MemPool` from `src/Dagger.jl` to resolve a precompilation error during testing an earlier version of the changes (though testing is currently unavailable).
- Renamed stencil documentation to `docs/src/stencils.md` and converted content to Markdown.
- Moved stencil tests to `test/array/stencil.jl`.
- Updated `test/runtests.jl` to reflect new test path and name ("Array - Stencils"), placing it after "Array - Random".
- Added a stencil quickstart section to `docs/src/index.md` with an example and link to the detailed stencil documentation.
- Corrected DArray constructor calls in the new quickstart section.
- Corrected expected output in Datadeps quickstart examples in `docs/src/index.md`.
- Moved the "Quickstart: Stencil Operations" section in `docs/src/index.md` to appear after the "Quickstart: Datadeps" section. - Reverted the expected output in the Datadeps examples in `docs/src/index.md` to their original, correct state.
jpsamaroo
commented
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From jules.google.com