Skip to content

Sch: Quietly fail to put do_tasks exception #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpsamaroo merged 2 commits into from
Aug 9, 2025
Merged

Sch: Quietly fail to put do_tasks exception #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fd25c4
Sch: Quietly fail to put do_tasks exception
jpsamaroo Aug 6, 2025
ee03046
Sch: Quietly exit reusable task loop
jpsamaroo Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sch/Sch.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,9 @@ function (ets::FireTaskSpec)()
bt = catch_backtrace()
# FIXME: Catch the correct task ID
thunk_id = first_task.thunk_id
put!(chan, TaskResult(pid, proc, thunk_id, CapturedException(err, bt), nothing))
if isopen(chan)
put!(chan, TaskResult(pid, proc, thunk_id, CapturedException(err, bt), nothing))
end
finally
@maybelog ctx timespan_finish(ctx, :fire, (;uid, worker=pid), nothing)
end
Expand Down
4 changes: 2 additions & 2 deletions src/utils/reuse.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,8 @@ function reusable_task_loop(chan::Channel{Any}, ready::Threads.Atomic{Bool})
while true
f = try
take!(chan)
catch
if !isopen(chan)
catch err
if !isopen(chan) || err isa InterruptException # scheduler exiting
return
else
rethrow()
Expand Down