Performance improvements to fannkuchredux-fast#36
Open
hycakir wants to merge 6 commits intoJuliaPerf:masterfrom
Open
Performance improvements to fannkuchredux-fast#36hycakir wants to merge 6 commits intoJuliaPerf:masterfrom
fannkuchredux-fast#36hycakir wants to merge 6 commits intoJuliaPerf:masterfrom
Conversation
remove atomic operations
replace `max` with definition convert `Int` to `Int8` without checks
Contributor
|
Could you squash this to a single commit, please? |
Contributor
Author
|
I am on mobile, right now. I will remove the |
Collaborator
|
Note that it is possible to also use the squash on merge button (sorry if this is already known). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.