[WIP] add source of fastest c++ benches#38
Open
SimonDanisch wants to merge 8 commits intoJuliaPerf:masterfrom
Open
[WIP] add source of fastest c++ benches#38SimonDanisch wants to merge 8 commits intoJuliaPerf:masterfrom
SimonDanisch wants to merge 8 commits intoJuliaPerf:masterfrom
Conversation
SimonDanisch
changed the title
non-Jedi
reviewed
Aug 22, 2019
Contributor
non-Jedi
left a comment
non-Jedi
left a comment
There was a problem hiding this comment.
Where are the "cmain.jl" files coming from? Are those just translations of the C++ programs? Can they be added to this repo separately, and is there a benefit to doing so?
| @@ -3,14 +3,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Should the changes to this file be cherry-picked out of this branch as an improvement to the existing Julia program?
| @@ -10,9 +10,6 @@ | |||
| using Distributed | |||
Contributor
There was a problem hiding this comment.
Should the changes to this file be cherry-picked out of this branch as an improvement to the existing Julia program?
| @@ -7,7 +7,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Should the changes to this file be cherry-picked out of this branch as an improvement to the existing Julia program?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.