Skip to content

More robustly prevent compiler from eliminating code to be benchmarked #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topolarity merged 3 commits into from
Dec 11, 2024
Merged

More robustly prevent compiler from eliminating code to be benchmarked #48

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
174c1fa
More robustly prevent compiler from eliminating code to be benchmarked
Zentrik Dec 11, 2024
624d863
Avoid calling `rand` if using `Base.donotdelete`.
Zentrik Dec 11, 2024
7c8e4d7
Only force `rand` to be outlined
Zentrik Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/LinuxPerf.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,12 @@ macro pstats(args...)
val = $(esc(expr))
disable_all!()
# trick the compiler not to eliminate the code
stats = rand() < 0 ? val : Stats(bench)
@static if isdefined(Base, :donotdelete)
Base.donotdelete(val)
stats = Stats(bench)
else
stats = @noinline rand() < 0 ? val : Stats(bench)
end
return stats::Stats
catch
rethrow()
Expand Down