Use the spec divergence half-angle#26
Merged
StackEnjoyer merged 3 commits intoJuliaPhysics:masterfrom Sep 1, 2025
Merged
Conversation
https://www.thorlabs.com/newgrouppage9.cfm?objectgroup_id=5281&pn=HRS015B > The HRS015B beam divergence of 1.4 ± 0.2 mrad is based on the 1/e² falloff, and is a full-angle measurement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 57 57
Lines 2793 2793
=======================================
Hits 1996 1996
Misses 797 797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for pointing this out! I have added additional fixes in order to update all plots and results here: https://github.com/JuliaPhysics/BeamletOptics.jl/tree/Fix-HeNe-divergence-angle This concerns the:
Please consider adding these changes to your fork/PR and I will add my review. Alternatively, I can merge the linked branch directly, with proper attribution to you of course. |
StackEnjoyer
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeamletOptics calculate the half-angle divergence (fine)
BeamletOptics.jl/src/Utils/OpticUtils.jl
Line 63 in 99636a3
but thorlabs specifies the full-angle:
So the actual M2 should be
1.13(that looks plausible for an He-Ne) rather than2.26.The last change displayed in the diff is actually only about
\ No newline at end of file(the line itself has not changed at all, only a newline character has been added automatically by github).