Skip to content

Use the spec divergence half-angle#26

Merged
StackEnjoyer merged 3 commits intoJuliaPhysics:masterfrom
ederag:patch-1
Sep 1, 2025
Merged

Use the spec divergence half-angle#26
StackEnjoyer merged 3 commits intoJuliaPhysics:masterfrom
ederag:patch-1

Conversation

@ederag
Copy link
Contributor

@ederag ederag commented Aug 30, 2025

BeamletOptics calculate the half-angle divergence (fine)

divergence_angle(λ, w0, M2) = M2 * λ /* w0)

but thorlabs specifies the full-angle:

The HRS015B beam divergence of 1.4 ± 0.2 mrad
is based on the 1/e² falloff, and is a full-angle measurement

So the actual M2 should be 1.13 (that looks plausible for an He-Ne) rather than 2.26.

The last change displayed in the diff is actually only about \ No newline at end of file
(the line itself has not changed at all, only a newline character has been added automatically by github).

https://www.thorlabs.com/newgrouppage9.cfm?objectgroup_id=5281&pn=HRS015B

> The HRS015B beam divergence of 1.4 ± 0.2 mrad
is based on the 1/e² falloff, and is a full-angle measurement
@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.46%. Comparing base (99636a3) to head (a3bf1c2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files          57       57           
  Lines        2793     2793           
=======================================
  Hits         1996     1996           
  Misses        797      797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StackEnjoyer
Copy link
Collaborator

Thanks for pointing this out! I have added additional fixes in order to update all plots and results here: https://github.com/JuliaPhysics/BeamletOptics.jl/tree/Fix-HeNe-divergence-angle

This concerns the:

  • detector size, since the spots and fringes are now smaller
  • intro fig, which now also displays the beam

Please consider adding these changes to your fork/PR and I will add my review. Alternatively, I can merge the linked branch directly, with proper attribution to you of course.

@StackEnjoyer StackEnjoyer self-requested a review September 1, 2025 12:02
@StackEnjoyer StackEnjoyer merged commit 0a9b281 into JuliaPhysics:master Sep 1, 2025
6 checks passed
@ederag ederag deleted the patch-1 branch September 1, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants