Raise the threshold of decay time from 1 yr to 1e+60 year#506
Merged
fhagemann merged 1 commit intoJuliaPhysics:mainfrom Jun 27, 2025
Merged
Conversation
fhagemann
added
enhancement
fhagemann
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the undergrads in our lab, @JunwenDiao, found that 207Bi didn't have beta decay as expected with the latest version of SolidStateDetectors.jl.
It was later found that the issue is the same I had when I simulated events for the HADES dataset with Geant4.jl, which is that since v11.2, the time for decay threshold has been changed to 1 year.
This PR could prevent others from stumbling on this in the future :)
The script and the config file used to generate the two plots are attached here.