Add multithreading support in the electric field calculation#509
Merged
Add multithreading support in the electric field calculation#509
Conversation
fhagemann
commented
Jul 9, 2025
Comment on lines
-160
to
-162
| if fieldvector_coordinates == :xyz | ||
| ef = convert_field_vectors_to_xyz(ef, axφ) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
Also, I removed fieldvector_coordinates from get_electric_field_from_potential, because I cannot think of a scenario where this should NOT be wanted..
Maybe this function can even be mutating to avoid allocating memory.
…ial` I do not see any scenario, in which the resulting electric field should NOT be xyz
03f4cdf to
4e2c897
Compare
oschulz
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we never did this before, but the electric field calculation did not support multithreading. Adding it can result in a significant speedup.
Example:
Before this PR:
After this PR (using 64 threads)
@oschulz Not sure if the increase in allocations is something to worry about or not, but it is definitely faster now.