Make corrections of impurity densities optional
#548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
fhagemann
changed the title
corrections of impurity densities optional
fhagemann
added a commit
that referenced
this pull request
Oct 26, 2025
(cherry picked from commit 610bcce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation for impurity density
correctionsrequires EVERY future impurity density to define a method(*)(scale, impurity_density)and(+)(offset, impurity_density).I have moved handling of
correctionsinto the generic constructor ofImpurityDensityand have implemented a default(*)(scale, impurity_density)and(+)(offset, impurity_density)that throws aConfigFileErrorfor impurity densities that do not define those methods.