Use vectors instead of points to move_charges_inside_semiconductor#553
Merged
fhagemann merged 3 commits intoJuliaPhysics:mainfrom Oct 29, 2025
Merged
Use vectors instead of points to move_charges_inside_semiconductor#553fhagemann merged 3 commits intoJuliaPhysics:mainfrom
move_charges_inside_semiconductor#553fhagemann merged 3 commits intoJuliaPhysics:mainfrom
Conversation
Collaborator
|
Can we add a test for this, to make sure that things like this are also tested in the future and covered by the tests? |
Collaborator
|
Downgrade tests failed because the current method of computing a weighted mean of |
Collaborator
Author
|
Thanks for adding the tests. I think this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsupported operations (since #489) with
CartesianPoint's were used inmove_charges_inside_semiconductorcausing errors when drifting charges (see #552)I switched them to vectors by using
point->point - cartesian_zero.This PR fixes these issues and correctly passes
verbosewhen usingmove_charges_inside_semiconductor