-
Notifications
You must be signed in to change notification settings - Fork 51
Fix plotting methods with new CartesianPoint implementation
#558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
commented
Nov 5, 2025
fhagemann
commented
Nov 5, 2025
Tests for `mean` are broken when using `SVectors`
oschulz
requested changes
Nov 6, 2025
e12b86e to
9689c70
Compare
Collaborator
Author
|
The latest commit to fix the Downgrade tests was needed because the newest versions of |
oschulz
approved these changes
Nov 12, 2025
Collaborator
Author
|
Just to have this documented: this PR also fixed the following issue:
MWE: using SolidStateDetectors, Geant4, Unitful
sim = Simulation{Float32}(SSD_examples[:InvertedCoax])
source = IsotopeSource(90, 228, 0.0, 0.0, CartesianPoint(0.05,0,0.05))
app = G4JLApplication(sim, source)
t = run_geant4_simulation(app, 1_000)
tc = SolidStateDetectors.cluster_detector_hits(t, 20u"μm")This is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #552: since #489, the plots for Box did not work properly (
verticeswere swapped and there is one line for sample surface, adding aPointto aVectorinstead of aVectorto aPoint).This should work now.
HOWEVER: all samplesurface plots appear empty in their default implementation, so something with
auto_strokewidthorauto_markersizedoes not seems to work well. This still needs to be revisited.i