Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
624a869
Function to define CylindricalPoint with units
claudiaalvgar Nov 10, 2025
cb2e603
Allow NBodyChargeCloud to receive CylindricalPoint in Floats and with…
claudiaalvgar Nov 10, 2025
fa00d52
Use the defined function to_internal_point to convert Points to Carte…
claudiaalvgar Nov 10, 2025
1f999ac
Fix manual with new behaviour
claudiaalvgar Nov 10, 2025
9482e5d
convert CartesianPoint to SVector to be returned from run_geant4_simu…
claudiaalvgar Nov 12, 2025
80be3b4
add test for bug found
claudiaalvgar Nov 12, 2025
5b3db1b
pass N and unify functions
claudiaalvgar Nov 12, 2025
9bfe583
restrict Unitful.Quantity
claudiaalvgar Nov 12, 2025
035398f
implemented suggestions
claudiaalvgar Nov 12, 2025
652d324
export to_internal_point function
claudiaalvgar Nov 12, 2025
2f0981d
Add tests for new NBodyChargeCloud functions
claudiaalvgar Nov 12, 2025
67343ad
comment erro line
claudiaalvgar Nov 13, 2025
6d6c103
add test
claudiaalvgar Nov 13, 2025
1df5e98
unify functions, just 1 function failed
claudiaalvgar Nov 13, 2025
c6a34e2
add functions to to_internal_units
claudiaalvgar Nov 13, 2025
09a64e3
added suggested changes
claudiaalvgar Nov 13, 2025
8d6268d
delete export to_internal_point
claudiaalvgar Nov 13, 2025
a266d8d
delete ucovert
claudiaalvgar Nov 13, 2025
ebe8db6
Add `LegendHDF5IO` support for `Cartesian/CylindricalPoint`
fhagemann Nov 14, 2025
a6a74a1
Revert "comment erro line"
fhagemann Nov 14, 2025
023d2cf
Revert "convert CartesianPoint to SVector to be returned from run_gea…
fhagemann Nov 14, 2025
a4dd5fe
put back Cylindrical test with units
claudiaalvgar Nov 14, 2025
f000ab8
change CylindricalPoint function and delete function to_internal_unit…
claudiaalvgar Nov 14, 2025
5fe6418
Update stripping units of `CylindricalPoint`
fhagemann Nov 15, 2025
253ec30
Add tests for units/type promotion of `CylindricalPoint`
fhagemann Nov 15, 2025
70b277b
convert cluster_radius to internal units
claudiaalvgar Nov 25, 2025
4416ac5
Add CartesianPoint constructor to avoid units
claudiaalvgar Nov 25, 2025
8e25960
uncomment tests
claudiaalvgar Nov 25, 2025
ddaa78c
remove units from test
claudiaalvgar Nov 25, 2025
366581b
add back units to pos
claudiaalvgar Nov 27, 2025
1f2eb34
add tests
claudiaalvgar Nov 27, 2025
f1e85c6
remove units
claudiaalvgar Nov 27, 2025
a700a07
account for suggestions
claudiaalvgar Nov 27, 2025
49c900c
Suggested changes and fix doc without units
claudiaalvgar Nov 28, 2025
efce348
No need to deal with units, the plot recipe will deal with this
fhagemann Nov 28, 2025
f6261ca
Strip position units in `simulate_waveforms` further down
fhagemann Nov 28, 2025
861e5db
Add test for different types of `pos` in `simulate_waveforms`
fhagemann Nov 28, 2025
cfba8d4
Ensure cluster radius is charge clustering has correct units
fhagemann Nov 28, 2025
92fedb0
Avoid converting `CartesianPoint` to `SVector` when writing to HDF5
fhagemann Nov 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_io.jl
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ end
detno = Int32[1],
thit = VectorOfVectors([T[0] * u"s"]),
edep = VectorOfVectors([T[1] * u"eV"]),
pos = VectorOfVectors([[SVector{3, T}.(0.01, 0.01, 0.01) * u"m"]])
pos = VectorOfVectors([[SVector{3, T}.(0.01, 0.01, 0.01)]])
)

contact_charge_signals = timed_simulate_waveforms(
Expand Down Expand Up @@ -111,4 +111,4 @@ end
end
rm("generated_waveforms_evts_1-1.h5")
end
end
end
Loading