Test Coverage for CartesianPoint: Part 2#571
Merged
fhagemann merged 5 commits intoJuliaPhysics:mainfrom Dec 5, 2025
Merged
Conversation
fhagemann
approved these changes
Dec 4, 2025
Collaborator
|
@claudiaalvgar Can you update the checklist in #552, so that we can see what's still missing? |
sm2909
pushed a commit
to sm2909/SolidStateDetectors.jl
that referenced
this pull request
Dec 7, 2025
* tests for CartesianVector * tests for Cone and general Geometry * test for modulate_driftvector * tests for Grid * Not support units in CartesianVector and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the second part of the list in #552 by adding tests to increase
CartesianPointandCartesianVectorcoverage.