Skip to content

Prevent infinite recursion of unit by adding a method unit(::Type{Any}) #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 15, 2025
Merged

Prevent infinite recursion of unit by adding a method unit(::Type{Any}) #807

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
330869f
Define unit(::Any)m unit(::Funciton) and add a type restriction to un…
SeSodesa Aug 29, 2025
51e81a5
test/dates: assume NoUnits instead of MethodErrors in the case of Dat…
SeSodesa Aug 30, 2025
4f2bf7f
Loosen the type restrictions of unit(::Type{Missing,T})
SeSodesa Sep 1, 2025
c230a6a
Fully qualify Dates.FixedPeriod in type restriction of method unit(x:…
SeSodesa Sep 1, 2025
fe1e225
Revert the Dates-related tests to throw MethodErrors instead of testi…
SeSodesa Sep 1, 2025
156ffe2
If a unit call bubbles up to unit(::Any), throw a DomainError
SeSodesa Sep 3, 2025
b43536b
Remove now-unnecessary comment about type restriction from unit(::Typ…
SeSodesa Sep 3, 2025
e071b61
Remove method unit(::Any), and move unit(::Type{Any}) for docstring p…
SeSodesa Sep 3, 2025
108bc4e
Change Dates-related tests to expect MethodErrors again, after the re…
SeSodesa Sep 3, 2025
16c7404
Shorten error message thrown by unit(Any)
SeSodesa Sep 5, 2025
6320332
Replace docstring of unit(::Type{Any}) with a simple comment
SeSodesa Sep 5, 2025
6af1980
Take Julia 1.6 compatibility into account with the unit(Any) error me…
SeSodesa Sep 10, 2025
7ea4b1f
Follow code style of project
SeSodesa Sep 15, 2025
48b9629
Further code style changes
SeSodesa Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,11 @@ julia> unit(1.0) == NoUnits
true
```
"""
@inline unit(x::Any) = NoUnits # In general, things do not have units.
@inline unit(x::Number) = NoUnits
@inline unit(x::Type{T}) where {T <: Number} = NoUnits
@inline unit(x::Type{Union{Missing, T}}) where T = unit(T)
@inline unit(x::Function) = NoUnits # Functions do not have units. Function values might.
@inline unit(x::Type{Union{Missing, T}}) where { T <: Number } = unit(T) # Type restriction required here for T, or might result in infinite recursion.
@inline unit(x::Type{Missing}) = missing
@inline unit(x::Missing) = missing

Expand Down
6 changes: 3 additions & 3 deletions test/dates.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
@test_throws MethodError dimension(T(1))
@test_throws MethodError Unitful.numtype(T)
@test_throws MethodError Unitful.numtype(T(1))
@test_throws MethodError unit(T)
@test_throws MethodError unit(T(1))
@test unit(T) == NoUnits
@test unit(T(1)) == NoUnits
end

for p = (CompoundPeriod, CompoundPeriod(), CompoundPeriod(Day(1)), CompoundPeriod(Day(1), Hour(-1)))
@test dimension(p) === 𝐓
@test_throws MethodError Unitful.numtype(p)
@test_throws MethodError unit(p)
@test unit(p) == NoUnits
end
end

Expand Down
Loading