-
Notifications
You must be signed in to change notification settings - Fork 61
Add floataside to Layout.jl #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi Jürgen, sorry for taking so long for this PR! This PR is difficult because the functionality is a bit "too revolutionary" for Pluto and I am not sure what is still needed to make it ready. The concerns I have are:
As an example, the features These concerns make it difficult for me to merge this into PlutoUI, because I want to make sure that the Pluto ecosystem feels reliable. But it would be nice to make it already available in its current state in an experimental phase? I propose that we release this in another package (but I know that you don't like releasing tiny Julia packages as much as me 😁), or we can put it in PlutoUI as "Experimental", like Layout. But then it would be nice if the mobile layout problem is clearly explained to users. |
|
Ok I see your point. My javascript skills are probably not sufficient for an automatic solution.... As it is already in Experimental, users are already aware of possible problems, we could add some of your concerns here to the docstring. And how experimental is ExperimentalLayout ? I use it quite a lot. If the main reason for calling it experimental is the fact that it does not work on mobile, it could be renamed "DesktopOnly" and released in the usual fashion ? |
|
Thanks for understanding! I have a project coming up with my work where I will use Layout more, and my plan is to make a final release afterwards 👍 |

Thank you for opening a Pull Request at PlutoUI.jl!
Before contributing code
Note that your code will be Unlicensed when added to PlutoUI.jl, not MIT licensed like contributions to Pluto.jl. Take a look at our license: https://github.com/fonsp/PlutoUI.jl/blob/main/LICENSE