You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice! I just tested this locally and it works well for me. Only minor comment would be that it would be nice if conda pip_add --editable ./path/to/my_package just worked to match regular pip behavior. Currently, the user has to do conda pip_add --editable my_package@./path/to/my_package and hits a confusing error if the stuff before the @ has a typo.
That said, I think UI/UX improvements can totally land in a future PR to avoid stalling this any longer.
Thanks for this and sorry for the delay in reviewing! Looks great. I made some small tweaks before merging but nothing drastic. Main change really was to the tests, just because some very similar tests got added in the meantime so I adapted those and removed yours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to do the equivalent of
pip install --editable <path/to/package>with CondaPkg.jl, as requested in #96