Skip to content

Test with PYTHON_JULIACALL_HANDLE_SIGNALS=yes #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Test with PYTHON_JULIACALL_HANDLE_SIGNALS=yes #642

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3384ff
remove unused type
Jul 15, 2025
052df20
test more python versions
Jul 15, 2025
03f44b8
correct field names and types
Jul 15, 2025
f17f0aa
use julia signal handling when testing python
Jul 15, 2025
26c5611
revert set of tested python versions
Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
pyversion: ["3", "3.8"]
pyversion: ["3.13", "3.12", "3.11", "3.10", "3.9", "3.8"]

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 2 additions & 4 deletions src/C/consts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,12 @@ end
vectorcall::Ptr{Cvoid} = C_NULL

# Python 3.12+ fields
tp_watched::Cchar = 0
watched::Cuchar = 0

# Python 3.13+ fields
tp_versions_used::Cushort = 0
versions_used::UInt16 = 0
Copy link
Contributor

@MilesCranmer MilesCranmer Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

julia> Cushort === UInt16
true

Copy link
Member Author

@cjdoris cjdoris Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily on all systems.

Copy link
Contributor

@MilesCranmer MilesCranmer Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, sorry.

Copy link
Contributor

@MilesCranmer MilesCranmer Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, which systems would this actually not be true for?

Copy link

@giordano giordano Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Julia the "C*" aliases are best guesses based on observed experience of common compilers (mainly gcc and clang), and in this specific case Cushort is indeed always UInt16: https://github.com/JuliaLang/julia/blob/11eeed32e8fe3cd24c8439fbe2220d3f4183f306/base/ctypes.jl#L27. But the reality is that the C standard doesn't specify fixed size for types, and leaves the implementation up to compilers which can do what the heck they want. "short" is only expected to be at least 16 bits, but a compiler making "short" 17 bits could be fully standard-compliant.

end

const PyTypePtr = Ptr{PyTypeObject}

@kwdef struct PySimpleObject{T}
ob_base::PyObject = PyObject()
value::T
Expand Down
Loading