Skip to content

Set compiled_modules=False automatically #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Set compiled_modules=False automatically #539

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e98516
Set `compiled_modules=False` automatically
Moelf Nov 3, 2023
48f1b8e
Update src/julia/core.py
Moelf Nov 3, 2023
791c8f1
Update src/julia/core.py
Moelf Nov 3, 2023
deff2c9
add auto as default
Moelf Nov 3, 2023
bfca4a2
add auto as default
Moelf Nov 3, 2023
76a5490
Update src/julia/options.py
Moelf Nov 3, 2023
d35b213
Fix docs for `compiled_modules`
MilesCranmer Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/julia/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,19 @@ def __init__(self, init_julia=True, jl_init_path=None, runtime=None,
logger.debug("use_custom_sysimage = %r", use_custom_sysimage)
logger.debug("compiled_modules = %r", options.compiled_modules)
if not (
options.compiled_modules == "no"
or is_compatible_python
is_compatible_python
or use_custom_sysimage
):
raise UnsupportedPythonError(jlinfo)
if options.compiled_modules in (True, "yes"):
raise UnsupportedPythonError(jlinfo)
elif options.compiled_modules in (False, "no"):
pass
else:
warnings.warn(
"Statically linked Python interpreter detected, setting `compiled_modules=False` automatically."
)
options.compiled_modules = "no"


self.api.init_julia(options)

Expand Down
2 changes: 1 addition & 1 deletion src/julia/tests/test_juliaoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
(dict(min_optlevel=2), ["--min-optlevel=2"]),
(dict(threads="auto", optimize=3), ["--optimize=3", '--threads=auto']),
(dict(optimize=3, threads="auto"), ["--optimize=3", '--threads=auto']), # passed order doesn't matter
(dict(compiled_modules=None, depwarn="yes"), ["--depwarn=yes"]),
(dict(compiled_modules="auto", depwarn="yes"), ["--depwarn=yes"]),
])
# fmt: on
def test_as_args(kwargs, args):
Expand Down