Skip to content

Make unsafe_load-based transmutes GC-protected #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunoru merged 3 commits into from
Sep 23, 2025
Merged

Make unsafe_load-based transmutes GC-protected #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75f142f
.gitignore: ignore VSCode settings file
pthariensflame Sep 17, 2025
15bb88a
Make unsafe_load-based transmute GC-protected
pthariensflame Sep 17, 2025
6a59a70
Reduce/update CI configuration
pthariensflame Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
julia-version: ["1.8", "1.10", nightly]
julia-version: ["1.8", "1.11", nightly]
julia-arch: [x64, x86, aarch64]
os: [ubuntu-latest, windows-latest, macos-13, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest]
exclude:
- os: ubuntu-latest
julia-arch: aarch64
- os: windows-latest
julia-arch: aarch64
- os: macos-13
julia-arch: x86
- os: macos-13
julia-arch: aarch64
- os: macos-latest
julia-arch: x86
- os: macos-latest
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ actual/
/deps/aes-ni
Manifest.toml
.DS_Store
.vscode/settings.json
4 changes: 2 additions & 2 deletions src/arm/aesni_common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ const LITTLE_ENDIAN::Bool = ENDIAN_BOM ≡ 0x04030201

abstract type ArmVec128 end
@inline Base.convert(::Type{T}, x::ArmVec128) where {T<:Union{ArmVec128, UInt128}} =
unsafe_load(Ptr{T}(pointer_from_objref(Ref(x))))
GC.@preserve x unsafe_load(Ptr{T}(pointer_from_objref(Ref(x))))
@inline Base.convert(::Type{T}, x::UInt128) where {T<:ArmVec128} =
unsafe_load(Ptr{T}(pointer_from_objref(Ref(x))))
GC.@preserve x unsafe_load(Ptr{T}(pointer_from_objref(Ref(x))))
@inline Base.UInt128(x::ArmVec128) = convert(UInt128, x)
@inline (::Type{T})(x::Union{ArmVec128, UInt128}) where {T<:ArmVec128} = convert(T, x)
@inline Base.convert(::Type{T}, x::Union{Signed, Unsigned}) where {T<:ArmVec128} =
Expand Down
2 changes: 1 addition & 1 deletion src/common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ abstract type R123Generator2x{T} <: AbstractR123{T} end
"RNG that generates four numbers at a time."
abstract type R123Generator4x{T} <: AbstractR123{T} end

_value(r::AbstractR123{T}, i = 1, ::Type{T2} = T) where {T, T2} = unsafe_load(Ptr{T2}(pointer_from_objref(r)), i)
_value(r::AbstractR123{T}, i = 1, ::Type{T2} = T) where {T, T2} = GC.@preserve r unsafe_load(Ptr{T2}(pointer_from_objref(r)), i)

"Set the counter of a Random123 RNG."
@inline function set_counter!(r::R123Generator1x{T}, ctr::Integer) where T <: UInt128
Expand Down
4 changes: 2 additions & 2 deletions src/x86/aesni_common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ const __m128i_lvec = NTuple{2, VecElement{UInt64}}
struct __m128i
data::__m128i_lvec
end
Base.convert(::Type{__m128i}, x::UInt128) = unsafe_load(Ptr{__m128i}(pointer_from_objref(Ref(x))))
Base.convert(::Type{UInt128}, x::__m128i) = unsafe_load(Ptr{UInt128}(pointer_from_objref(Ref(x))))
Base.convert(::Type{__m128i}, x::UInt128) = GC.@preserve x unsafe_load(Ptr{__m128i}(pointer_from_objref(Ref(x))))
Base.convert(::Type{UInt128}, x::__m128i) = GC.@preserve x unsafe_load(Ptr{UInt128}(pointer_from_objref(Ref(x))))
Base.UInt128(x::__m128i) = convert(UInt128, x)
__m128i(x::UInt128) = convert(__m128i, x)
Base.convert(::Type{__m128i}, x::Union{Signed, Unsigned}) = convert(__m128i, UInt128(x))
Expand Down
Loading