Add instructions for moving a package into a subdirectory #145437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GunnarFarneback
force-pushed
the
patch-1
branch
from
81f1828 to
c309c78
Compare
giordano
previously approved these changes
Jan 13, 2026
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
Looks good, thanks. Minor comment: it'd be caught by the automerge checks anyway, but is it worth pointing out that the new subdir needs to contain the license file in its top level?
Contributor
Author
|
Sounds like a good idea. Added. |
giordano
previously approved these changes
Jan 13, 2026
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
I'll merge it tomorrow if there are no objections.
giordano
reviewed
Jan 13, 2026
Co-authored-by: Mosè Giordano <[email protected]>
ericphanson
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens now and then that people move packages into subdirectories and best practice should be documented.