Add CI workflow to validate web service deployability #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs serverless package on PRs/pushes that modify web service files to catch config errors before merge. Co-authored-by: Claude <[email protected]>
Serverless v3+ has native support for AWS pseudo parameters.
Use ${aws:region} and ${aws:accountId} instead of #{AWS::...} syntax.
Co-authored-by: Claude <[email protected]>
Serverless v4 requires authentication. Pass access key from secrets. Co-authored-by: Claude <[email protected]>
(cherry picked from commit 3fbf9a6)
The ${aws:region} and ${aws:accountId} variables need AWS credentials
to resolve, even for packaging. Use dummy values since we're not deploying.
Co-authored-by: Claude <[email protected]>
Replace ${aws:region} and ${aws:accountId} with CloudFormation
intrinsic functions (${AWS::Region}, ${AWS::AccountId}) which are
resolved at deploy time, not package time.
Co-authored-by: Claude <[email protected]>
Serverless v4 requires real AWS credentials for packaging. Use aws-actions/configure-aws-credentials with OIDC for secure, short-lived credentials without storing long-term secrets. Requires one-time AWS setup: 1. Create IAM Identity Provider for GitHub OIDC 2. Create IAM Role with trust policy for this repo 3. Add AWS_ROLE_ARN to repository secrets Co-authored-by: Claude <[email protected]>
Pin to Serverless v3.39 which does not require AWS credentials for packaging validation. Added docs/TODO-serverless-v4.md with instructions for upgrading to v4 when AWS OIDC is configured. Co-authored-by: Claude <[email protected]>
IanButterworth
force-pushed
the
ib/server_test
branch
from
bbc26c3 to
64c8b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs serverless package on PRs/pushes that modify web service files to catch config errors before merge.