Skip to content

Commit 0331d93

Browse files
committed
Mini rename and adding to FileDFG test
1 parent 09fbd5e commit 0331d93

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

src/DistributedFactorGraphs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export InferenceType, PackedInferenceType, FunctorInferenceType, InferenceVariab
2323
export FunctorSingleton, FunctorPairwise, FunctorPairwiseMinimize
2424
export getMaxPPE, getMeanPPE, getSuggestedPPE, getVariablePPE, getPPE, getVariablePPEs, getPPEs #, getEstimates
2525
export timestamp # DEPRECATED
26-
export getSolved, isSolved, setSolved!
26+
export getSolvedCount, isSolved, setSolvedCount!
2727
export label, getTimestamp, setTimestamp!, tags, setTags!, estimates, estimate, data, softtype, solverData, getData, solverDataDict, setSolverData, setSolverData!, internalId, smallData, setSmallData!, bigData
2828
export DFGVariableSummary, DFGFactorSummary, AbstractDFGSummary
2929
export addBigDataEntry!, getBigDataEntry, updateBigDataEntry!, deleteBigDataEntry!, getBigDataEntries, getBigDataKeys

src/entities/DFGVariable.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,11 @@ Get the number of times a variable has been inferred -- i.e. `solvedCount`.
308308
309309
Related
310310
311-
isSolved, setSolved!
311+
isSolved, setSolvedCount!
312312
"""
313-
getSolved(v::VariableNodeData) = v.solvedCount
314-
getSolved(v::VariableDataLevel2, solveKey::Symbol=:default) = solverData(v, solveKey) |> getSolved
315-
getSolved(dfg::AbstractDFG, sym::Symbol, solveKey::Symbol=:default) = getSolved(getVariable(dfg, sym), solveKey)
313+
getSolvedCount(v::VariableNodeData) = v.solvedCount
314+
getSolvedCount(v::VariableDataLevel2, solveKey::Symbol=:default) = solverData(v, solveKey) |> getSolvedCount
315+
getSolvedCount(dfg::AbstractDFG, sym::Symbol, solveKey::Symbol=:default) = getSolved(getVariable(dfg, sym), solveKey)
316316

317317
"""
318318
$SIGNATURES
@@ -337,9 +337,9 @@ Related
337337
338338
getSolved, isSolved
339339
"""
340-
setSolved!(v::VariableNodeData, val::Int) = v.solvedCount = val
341-
setSolved!(v::VariableDataLevel2, val::Int, solveKey::Symbol=:default) = setSolved!(solverData(v, solveKey), val)
342-
setSolved!(dfg::AbstractDFG, sym::Symbol, val::Int, solveKey::Symbol=:default) = setSolved!(getVariable(dfg, sym), solveKey, val)
340+
setSolvedCount!(v::VariableNodeData, val::Int) = v.solvedCount = val
341+
setSolvedCount!(v::VariableDataLevel2, val::Int, solveKey::Symbol=:default) = setSolvedCount!(solverData(v, solveKey), val)
342+
setSolvedCount!(dfg::AbstractDFG, sym::Symbol, val::Int, solveKey::Symbol=:default) = setSolved!(getVariable(dfg, sym), solveKey, val)
343343

344344

345345
"""

test/fileDFGTests.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
using DistributedFactorGraphs
2+
using IncrementalInference
3+
dfg = LightDFG{NoSolverParams}()
4+
15
@testset "FileDFG Tests" begin
26

37
if typeof(dfg) <: CloudGraphsDFG
@@ -14,6 +18,7 @@
1418
verts[7].solvable = 1
1519
verts[8].solvable = 0
1620
solverData(verts[8]).solveInProgress = 1
21+
setSolvedCount!(verts[1], 5)
1722
#call update to set it on cloud
1823
updateVariable!(dfg, verts[7])
1924
updateVariable!(dfg, verts[8])

test/interfaceTests.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,9 @@ end
214214
# test solveCount for variable
215215
# vari = getVariable(dfg, v1)
216216
@test !isSolved(v1)
217-
@test getSolved(v1) == 0
218-
setSolved!(v1, 1)
219-
@test getSolved(v1) == 1
217+
@test getSolvedCount(v1) == 0
218+
setSolvedCount!(v1, 1)
219+
@test getSolvedCount(v1) == 1
220220
@test isSolved(v1)
221221

222222
# Session, robot, and user small data tests

0 commit comments

Comments
 (0)