Skip to content

Commit 2139096

Browse files
authored
Merge pull request #224 from JuliaRobotics/format/tab4space
tab = 4 spaces
2 parents 728d0fb + 6b40f36 commit 2139096

File tree

10 files changed

+613
-612
lines changed

10 files changed

+613
-612
lines changed

src/CloudGraphsDFG/services/CGStructure.jl

Lines changed: 125 additions & 125 deletions
Large diffs are not rendered by default.

src/Common.jl

Lines changed: 58 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -47,51 +47,51 @@ end
4747
Sort a variable list which may have nested structure such as `:x1_2` -- does not sort for alphabetic characters.
4848
"""
4949
function sortVarNested(vars::Vector{Symbol})::Vector{Symbol}
50-
# whos nested and first numeric character offset
51-
sv = string.(vars)
52-
offsets = getFirstNumericalOffset.(sv)
53-
masknested = isnestednum.(sv)
54-
masknotnested = true .⊻ masknested
55-
56-
# strip alphabetic characters from front
57-
msv = sv[masknotnested]
58-
msvO = offsets[masknotnested]
59-
nsv = sv[masknested]
60-
nsvO = offsets[masknested]
61-
62-
# do nonnested list separately
63-
nnreducelist = map((s,o) -> s[o:end], msv, msvO)
64-
nnintlist = parse.(Int, nnreducelist)
65-
nnp = sortperm(nnintlist)
66-
nnNums = nnintlist[nnp] # used in mixing later
67-
nonnested = msv[nnp]
68-
smsv = vars[masknotnested][nnp]
69-
70-
# do nested list separately
71-
nestedreducelist = map((s,o) -> s[o:end], nsv, nsvO)
72-
nestedp = sortnestedperm(nestedreducelist)
73-
nesNums = parse.(Int, getindex.(split.(nestedreducelist[nestedp], '_'),1)) # used in mixing later
74-
nested = nsv[nestedp]
75-
snsv = vars[masknested][nestedp]
76-
77-
# mix back together, pick next sorted item from either pile
78-
retvars = Vector{Symbol}(undef, length(vars))
79-
nni = 1
80-
nesi = 1
81-
lsmsv = length(smsv)
82-
lsnsv = length(snsv)
83-
MAXMAX = 999999999999
84-
for i in 1:length(vars)
85-
# inner ifs to ensure bounds and correct sorting at end of each list
86-
if (nni<=lsmsv ? nnNums[nni] : MAXMAX) <= (nesi<=lsnsv ? nesNums[nesi] : MAXMAX)
87-
retvars[i] = smsv[nni]
88-
nni += 1
89-
else
90-
retvars[i] = snsv[nesi]
91-
nesi += 1
92-
end
93-
end
94-
return retvars
50+
# whos nested and first numeric character offset
51+
sv = string.(vars)
52+
offsets = getFirstNumericalOffset.(sv)
53+
masknested = isnestednum.(sv)
54+
masknotnested = true .⊻ masknested
55+
56+
# strip alphabetic characters from front
57+
msv = sv[masknotnested]
58+
msvO = offsets[masknotnested]
59+
nsv = sv[masknested]
60+
nsvO = offsets[masknested]
61+
62+
# do nonnested list separately
63+
nnreducelist = map((s,o) -> s[o:end], msv, msvO)
64+
nnintlist = parse.(Int, nnreducelist)
65+
nnp = sortperm(nnintlist)
66+
nnNums = nnintlist[nnp] # used in mixing later
67+
nonnested = msv[nnp]
68+
smsv = vars[masknotnested][nnp]
69+
70+
# do nested list separately
71+
nestedreducelist = map((s,o) -> s[o:end], nsv, nsvO)
72+
nestedp = sortnestedperm(nestedreducelist)
73+
nesNums = parse.(Int, getindex.(split.(nestedreducelist[nestedp], '_'),1)) # used in mixing later
74+
nested = nsv[nestedp]
75+
snsv = vars[masknested][nestedp]
76+
77+
# mix back together, pick next sorted item from either pile
78+
retvars = Vector{Symbol}(undef, length(vars))
79+
nni = 1
80+
nesi = 1
81+
lsmsv = length(smsv)
82+
lsnsv = length(snsv)
83+
MAXMAX = 999999999999
84+
for i in 1:length(vars)
85+
# inner ifs to ensure bounds and correct sorting at end of each list
86+
if (nni<=lsmsv ? nnNums[nni] : MAXMAX) <= (nesi<=lsnsv ? nesNums[nesi] : MAXMAX)
87+
retvars[i] = smsv[nni]
88+
nni += 1
89+
else
90+
retvars[i] = snsv[nesi]
91+
nesi += 1
92+
end
93+
end
94+
return retvars
9595
end
9696

9797
"""
@@ -277,7 +277,7 @@ end
277277
"""
278278
$(SIGNATURES)
279279
Gives back all factor labels that fit the bill:
280-
lsWho(dfg, :Pose3)
280+
lsWho(dfg, :Pose3)
281281
282282
Dev Notes
283283
- Cloud versions will benefit from less data transfer
@@ -289,19 +289,19 @@ ls, lsf, lsfPriors
289289
"""
290290
function lsWho(dfg::AbstractDFG, type::Symbol; solveKey::Symbol=:default)::Vector{Symbol}
291291
vars = getVariables(dfg)
292-
labels = Symbol[]
292+
labels = Symbol[]
293293
for v in vars
294-
varType = typeof(getVariableType(v, solveKey=solveKey)).name |> Symbol
295-
varType == type && push!(labels, v.label)
296-
end
297-
return labels
294+
varType = typeof(getVariableType(v, solveKey=solveKey)).name |> Symbol
295+
varType == type && push!(labels, v.label)
296+
end
297+
return labels
298298
end
299299

300300

301301
"""
302302
$(SIGNATURES)
303303
Gives back all factor labels that fit the bill:
304-
lsfWho(dfg, :Point2Point2)
304+
lsfWho(dfg, :Point2Point2)
305305
306306
Dev Notes
307307
- Cloud versions will benefit from less data transfer
@@ -312,11 +312,11 @@ Related
312312
ls, lsf, lsfPriors
313313
"""
314314
function lsfWho(dfg::AbstractDFG, type::Symbol)::Vector{Symbol}
315-
facs = getFactors(dfg)
316-
labels = Symbol[]
315+
facs = getFactors(dfg)
316+
labels = Symbol[]
317317
for f in facs
318-
facType = typeof(getFactorType(f)).name |> Symbol
319-
facType == type && push!(labels, f.label)
320-
end
321-
return labels
318+
facType = typeof(getFactorType(f)).name |> Symbol
319+
facType == type && push!(labels, f.label)
320+
end
321+
return labels
322322
end

src/DFGPlots/DFGPlots.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ end
2424
DFGPlotProps() = DFGPlotProps( (var=colorant"seagreen", fac=colorant"cyan3"),
2525
(var=1.0, fac=0.3),
2626
(var=:box, fac=:elipse),
27-
spectral_layout,
27+
spring_layout,
2828
true)
2929

3030

src/GraphsDFG/services/GraphsDFG.jl

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,18 @@ end
2828
# Get user, robot, and session "small" data.
2929
getUserData(dfg::GraphsDFG)::Dict{Symbol, String} = return dfg.userData
3030
function setUserData(dfg::GraphsDFG, data::Dict{Symbol, String})::Bool
31-
dfg.userData = data
32-
return true
31+
dfg.userData = data
32+
return true
3333
end
3434
getRobotData(dfg::GraphsDFG)::Dict{Symbol, String} = return dfg.robotData
3535
function setRobotData(dfg::GraphsDFG, data::Dict{Symbol, String})::Bool
36-
dfg.robotData = data
37-
return true
36+
dfg.robotData = data
37+
return true
3838
end
3939
getSessionData(dfg::GraphsDFG)::Dict{Symbol, String} = return dfg.sessionData
4040
function setSessionData(dfg::GraphsDFG, data::Dict{Symbol, String})::Bool
41-
dfg.sessionData = data
42-
return true
41+
dfg.sessionData = data
42+
return true
4343
end
4444

4545
"""
@@ -48,10 +48,10 @@ Gets an empty and unique CloudGraphsDFG derived from an existing DFG.
4848
"""
4949
function _getDuplicatedEmptyDFG(dfg::GraphsDFG)::GraphsDFG
5050
newDfg = GraphsDFG{typeof(dfg.solverParams)}(;
51-
userId=dfg.userId, robotId=dfg.robotId, sessionId=dfg.sessionId,
52-
params=deepcopy(dfg.solverParams))
53-
newDfg.description ="(Copy of) $(dfg.description)"
54-
return newDfg
51+
userId=dfg.userId, robotId=dfg.robotId, sessionId=dfg.sessionId,
52+
params=deepcopy(dfg.solverParams))
53+
newDfg.description ="(Copy of) $(dfg.description)"
54+
return newDfg
5555
end
5656

5757
"""
@@ -256,11 +256,11 @@ function getVariables(dfg::GraphsDFG,
256256
end
257257

258258
# filter on tags
259-
if length(tags) > 0
259+
if length(tags) > 0
260260
mask = map(v -> length(intersect(v.tags, tags)) > 0, variables )
261261
return variables[mask]
262262
end
263-
return variables
263+
return variables
264264
end
265265

266266
"""
@@ -269,12 +269,12 @@ List the DFGFactors in the DFG.
269269
Optionally specify a label regular expression to retrieves a subset of the factors.
270270
"""
271271
function getFactors(dfg::GraphsDFG, regexFilter::Union{Nothing, Regex}=nothing; solvable::Int=0)::Vector{DFGFactor}
272-
factors = map(v -> v.dfgNode, filter(n -> (n.dfgNode isa DFGFactor) && (solvable != 0 ? solvable <= isSolvable(n.dfgNode) : true), Graphs.vertices(dfg.g)))
272+
factors = map(v -> v.dfgNode, filter(n -> (n.dfgNode isa DFGFactor) && (solvable != 0 ? solvable <= isSolvable(n.dfgNode) : true), Graphs.vertices(dfg.g)))
273273

274-
if regexFilter != nothing
275-
factors = filter(f -> occursin(regexFilter, String(f.label)), factors)
276-
end
277-
return factors
274+
if regexFilter != nothing
275+
factors = filter(f -> occursin(regexFilter, String(f.label)), factors)
276+
end
277+
return factors
278278
end
279279

280280
"""
@@ -296,7 +296,7 @@ function getNeighbors(dfg::GraphsDFG, node::T; solvable::Int=0)::Vector{Symbol}
296296
vert = dfg.g.vertices[dfg.labelDict[node.label]]
297297
neighbors = in_neighbors(vert, dfg.g) #Don't use out_neighbors! It enforces directiveness even if we don't want it
298298
# Additional filtering
299-
neighbors = solvable != 0 ? filter(v -> solvable <= isSolvable(v.dfgNode), neighbors) : neighbors
299+
neighbors = solvable != 0 ? filter(v -> solvable <= isSolvable(v.dfgNode), neighbors) : neighbors
300300
# Variable sorting (order is important)
301301
if node isa DFGFactor
302302
order = intersect(node._variableOrderSymbols, map(v->v.dfgNode.label, neighbors))
@@ -367,5 +367,5 @@ end
367367
Produces a dot-format of the graph for visualization.
368368
"""
369369
function toDot(dfg::GraphsDFG)::String
370-
return Graphs.to_dot(dfg.g)
370+
return Graphs.to_dot(dfg.g)
371371
end

0 commit comments

Comments
 (0)