Merge pull request #940 from JuliaRobotics/23Q1/depr/drop18

rm depr pre-v0.19

Author: dehann

src/Deprecated.jl

@@ -60,95 +60,92 @@ function getTypeFromSerializationModule(dfg::G, moduleType::Symbol) where G <: A
 end
 
 ## ================================================================================
-## Deprecate before v0.19 - Kept longer with error
+## Deprecate before v0.20
 ##=================================================================================
 
-Base.getproperty(x::VariableNodeData,f::Symbol) = begin
-  if f == :inferdim
-    error("vnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
-  else
-    getfield(x,f)
-  end
-end
-
-function Base.setproperty!(x::VariableNodeData, f::Symbol, val)
-  if f == :inferdim
-    error("vnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
-  end
-  return setfield!(x, f, convert(fieldtype(typeof(x), f), val))
-end
-
-Base.getproperty(x::PackedVariableNodeData,f::Symbol) = begin
-  if f == :inferdim
-    error("pvnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
-  else
-    getfield(x,f)
-  end
-end
-
-function Base.setproperty!(x::PackedVariableNodeData, f::Symbol, val)
-  if f == :inferdim
-    error("pvnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
-  end
-  return setfield!(x, f, convert(fieldtype(typeof(x), f), val))
-end
+export DefaultDFG
 
+const DefaultDFG = GraphsDFG
 
+export LightDFG
+LightDFG(args...; kwargs...) = error("LightDFG is deprecated and replaced with GraphsDFG")
 
-function VariableNodeData(val::Vector,
-                          bw::AbstractMatrix{<:Real},
-                          BayesNetOutVertIDs::AbstractVector{Symbol},
-                          dimIDs::AbstractVector{Int},
-                          dims::Int,
-                          eliminated::Bool,
-                          BayesNetVertID::Symbol,
-                          separator::AbstractVector{Symbol},
-                          variableType,
-                          initialized::Bool,
-                          inferdim::Real,
-                          w...; kw...)
-  error("VariableNodeData field inferdim was deprecated and is now obsolete, use infoPerCoord instead")
-end
 
+# better deprecation cycle from before v0.19
+@deprecate deepcopySupersolve!(w...;kw...) cloneSolveKey!(w...;kw...)
+@deprecate deepcopySolvekeys!(w...;kw...) cloneSolveKey!(w...;kw...)
 
 
 ## ================================================================================
-## Deprecate before v0.19
+## Deprecate before v0.19 - Kept longer with error
 ##=================================================================================
 
-# FIXME, change this to a deprecation in v0.19
-export deepcopySupersolve!, deepcopySolvekeys!
-const deepcopySupersolve! = cloneSolveKey!
-# @deprecate deepcopySupersolve!(w...;kw...) cloneSolveKey!(w...;kw...)
-const deepcopySolvekeys! = cloneSolveKey!
-# @deprecate deepcopySolvekeys!(w...;kw...) cloneSolveKey!(w...;kw...)
+# Base.getproperty(x::VariableNodeData,f::Symbol) = begin
+#   if f == :inferdim
+#     error("vnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
+#   else
+#     getfield(x,f)
+#   end
+# end
 
-@deprecate dfgplot(w...;kw...) plotDFG(w...;kw...)
+# function Base.setproperty!(x::VariableNodeData, f::Symbol, val)
+#   if f == :inferdim
+#     error("vnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
+#   end
+#   return setfield!(x, f, convert(fieldtype(typeof(x), f), val))
+# end
 
-export FunctorInferenceType, PackedInferenceType
+# Base.getproperty(x::PackedVariableNodeData,f::Symbol) = begin
+#   if f == :inferdim
+#     error("pvnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
+#   else
+#     getfield(x,f)
+#   end
+# end
 
-const FunctorInferenceType = AbstractFactor       # will eventually deprecate
-const PackedInferenceType = AbstractPackedFactor  # will eventually deprecate
+# function Base.setproperty!(x::PackedVariableNodeData, f::Symbol, val)
+#   if f == :inferdim
+#     error("pvnd.inferdim::Float64 was deprecated and is now obsolete, use vnd.infoPerCoord::Vector{Float64} instead")
+#   end
+#   return setfield!(x, f, convert(fieldtype(typeof(x), f), val))
+# end
 
-## ================================================================================
-## Deprecate before v0.20
-##=================================================================================
 
-export DefaultDFG
 
-const DefaultDFG = GraphsDFG
+# function VariableNodeData(val::Vector,
+#                           bw::AbstractMatrix{<:Real},
+#                           BayesNetOutVertIDs::AbstractVector{Symbol},
+#                           dimIDs::AbstractVector{Int},
+#                           dims::Int,
+#                           eliminated::Bool,
+#                           BayesNetVertID::Symbol,
+#                           separator::AbstractVector{Symbol},
+#                           variableType,
+#                           initialized::Bool,
+#                           inferdim::Real,
+#                           w...; kw...)
+#   error("VariableNodeData field inferdim was deprecated and is now obsolete, use infoPerCoord instead")
+# end
 
-export LightDFG
-LightDFG(args...; kwargs...) = error("LightDFG is deprecated and replaced with GraphsDFG")
 
 
 ## ================================================================================
-## Deprecate before v0.20
+## Deprecate before v0.19
 ##=================================================================================
 
-# FIXME uncomment before start of v0.19
-# @deprecate deepcopySupersolve!(w...;kw...) cloneSolveKey!(w...;kw...)
-# @deprecate deepcopySolvekeys!(w...;kw...) cloneSolveKey!(w...;kw...)
+# # FIXME, change this to a deprecation in v0.19
+# export deepcopySupersolve!, deepcopySolvekeys!
+# const deepcopySupersolve! = cloneSolveKey!
+# # @deprecate deepcopySupersolve!(w...;kw...) cloneSolveKey!(w...;kw...)
+# const deepcopySolvekeys! = cloneSolveKey!
+# # @deprecate deepcopySolvekeys!(w...;kw...) cloneSolveKey!(w...;kw...)
+
+# @deprecate dfgplot(w...;kw...) plotDFG(w...;kw...)
+
+# export FunctorInferenceType, PackedInferenceType
+
+# const FunctorInferenceType = AbstractFactor       # will eventually deprecate
+# const PackedInferenceType = AbstractPackedFactor  # will eventually deprecate
 
 
 #