remove human constructor need with filter fields

Author: dehann

src/services/Serialization.jl

@@ -207,10 +207,12 @@ function transcodeType(
     _srckeys(s) = fieldnames(typeof(s))
     _srcvals(s::AbstractDict) = values(s)
     _srcvals(s) = map(k->getproperty(s,k), _srckeys(s))  
+    # NOTE, improvement, filter extraneous fields not in _names
+    arr = [makething(Symbol(k),v) for (k,v) in zip(_srckeys(inObj),_srcvals(inObj))]
+    filter!(s->s[1] in _names, arr)
     # create dict provided fields into a NamedTuple as a type stable "pre-struct"
-    nt = (;(makething(Symbol(k),v) for (k,v) in zip(_srckeys(inObj),_srcvals(inObj)))...)
+    nt = (;arr...)
     # use keyword constructors provided by Base.@kwdef to resolve random ordering, incomplete dicts, and defaults
-    # TODO, improvement, filter extraneous fields not in _names
     T(;nt...)
 end
 

test/testTranscodeTypeUnmarshaling.jl

@@ -15,15 +15,14 @@ Base.@kwdef struct HardType
     time::DateTime = now(UTC)
     val::Float64 = 0.0
 end
-
-# slight human overhead for each type to ignore extraneous field construction
-# TODO, devnote drop this requirement with filter of _names in transcodeType
-HardType(;
-    name::String,
-    time::DateTime = now(UTC),
-    val::Float64 = 0.0,
-    ignorekws...
-) = HardType(name,time,val)
+  # # slight human overhead for each type to ignore extraneous field construction
+  # # TODO, devnote drop this requirement with filter of _names in transcodeType
+  # HardType(;
+  #     name::String,
+  #     time::DateTime = now(UTC),
+  #     val::Float64 = 0.0,
+  #     ignorekws...
+  # ) = HardType(name,time,val)
 
 @testset "Test transcoding of Intermediate, Dict, OrderedDict to a HardType" begin