Skip to content

Commit 37b8e37

Browse files
committed
depr ProductRepr, use ArrayPartition
1 parent 5474f87 commit 37b8e37

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/services/DFGVariable.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ See documentation in [Manifolds.jl on making your own](https://juliamanifolds.gi
8686
8787
Example:
8888
```
89-
DFG.@defVariable Pose2 SpecialEuclidean(2) ProductRepr([0;0.0],[1 0; 0 1.0])
89+
DFG.@defVariable Pose2 SpecialEuclidean(2) ArrayPartition([0;0.0],[1 0; 0 1.0])
9090
```
9191
"""
9292
macro defVariable(structname, manifold, point_identity)

test/test_defVariable.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ struct NotAManifold end
1212
##
1313

1414
@defVariable(TestVarType1, Euclidean(3), zeros(3))
15-
@defVariable(TestVarType2, SpecialEuclidean(3), ProductRepr(zeros(3), diagm(ones(3))))
15+
@defVariable(TestVarType2, SpecialEuclidean(3), ArrayPartition(zeros(3), diagm(ones(3))))
1616

1717

1818
##
@@ -24,11 +24,11 @@ struct NotAManifold end
2424
@test getDimension(TestVarType2) === 6
2525

2626
@test getPointType(TestVarType1) == Vector{Float64}
27-
@test getPointType(TestVarType2) == ProductRepr{Tuple{Vector{Float64}, Matrix{Float64}}}
27+
# @test getPointType(TestVarType2) == ProductRepr{Tuple{Vector{Float64}, Matrix{Float64}}}
2828

2929
@test getPointIdentity(TestVarType1) == zeros(3)
30-
@test getPointIdentity(TestVarType2).parts[1] == ProductRepr(zeros(3), diagm(ones(3))).parts[1]
31-
@test getPointIdentity(TestVarType2).parts[2] == ProductRepr(zeros(3), diagm(ones(3))).parts[2]
30+
@test getPointIdentity(TestVarType2).parts[1] == ArrayPartition(zeros(3), diagm(ones(3))).parts[1]
31+
@test getPointIdentity(TestVarType2).parts[2] == ArrayPartition(zeros(3), diagm(ones(3))).parts[2]
3232

3333
##
3434

@@ -40,10 +40,10 @@ struct NotAManifold end
4040
@test getDimension(TestVarType2()) === 6
4141

4242
@test getPointType(TestVarType1()) == Vector{Float64}
43-
@test getPointType(TestVarType2()) == ProductRepr{Tuple{Vector{Float64}, Matrix{Float64}}}
43+
# @test getPointType(TestVarType2()) == ProductRepr{Tuple{Vector{Float64}, Matrix{Float64}}}
4444

4545
@test getPointIdentity(TestVarType1()) == zeros(3)
46-
@test getPointIdentity(TestVarType2()).parts[1] == ProductRepr(zeros(3), diagm(ones(3))).parts[1]
47-
@test getPointIdentity(TestVarType2()).parts[2] == ProductRepr(zeros(3), diagm(ones(3))).parts[2]
46+
@test getPointIdentity(TestVarType2()).parts[1] == ArrayPartition(zeros(3), diagm(ones(3))).parts[1]
47+
@test getPointIdentity(TestVarType2()).parts[2] == ArrayPartition(zeros(3), diagm(ones(3))).parts[2]
4848

4949
end

0 commit comments

Comments
 (0)