Skip to content

Commit 3aa2247

Browse files
committed
TODOs
1 parent 6462896 commit 3aa2247

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/CloudGraphsDFG/services/CloudGraphsDFG.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ end
522522
### These functions write back as you add the data.
523523

524524
function addVariableSolverData!(dfg::CloudGraphsDFG, variablekey::Symbol, vnd::VariableNodeData, solvekey::Symbol=:default)::VariableNodeData
525-
# TODO: Just get the property, update it, and send it back
525+
# TODO: Switch out to their own nodes, don't get the whole variable
526526
var = getVariable(dfg, variablekey)
527527
if haskey(var.solverDataDict, solvekey)
528528
error("VariableNodeData '$(solvekey)' already exists")
@@ -539,7 +539,7 @@ function addVariableSolverData!(dfg::CloudGraphsDFG, variablekey::Symbol, vnd::V
539539
end
540540

541541
function updateVariableSolverData!(dfg::CloudGraphsDFG, variablekey::Symbol, vnd::VariableNodeData, solvekey::Symbol=:default)::VariableNodeData
542-
#This is basically just setSolverData
542+
# TODO: Switch out to their own nodes, don't get the whole variable
543543
var = getVariable(dfg, variablekey)
544544
if !haskey(var.solverDataDict, solvekey)
545545
@warn "VariableNodeData '$(solvekey)' does not exist, adding"
@@ -556,13 +556,15 @@ function updateVariableSolverData!(dfg::CloudGraphsDFG, variablekey::Symbol, vnd
556556
end
557557

558558
function updateVariableSolverData!(dfg::CloudGraphsDFG, sourceVariables::Vector{<:DFGVariable}, solvekey::Symbol=:default)
559+
# TODO: Switch out to their own nodes, don't get the whole variable
559560
#TODO: Do in bulk for speed.
560561
for var in sourceVariables
561562
updateVariableSolverData!(dfg, var.label, getSolverData(var, solvekey), solvekey)
562563
end
563564
end
564565

565566
function deleteVariableSolverData!(dfg::CloudGraphsDFG, variablekey::Symbol, solvekey::Symbol=:default)::VariableNodeData
567+
# TODO: Switch out to their own nodes, don't get the whole variable
566568
var = getVariable(dfg, variablekey)
567569

568570
if !haskey(var.solverDataDict, solvekey)

0 commit comments

Comments
 (0)