Remove FolderStore .dat legacy extension (#1078)

* Breaking: Fix FolderStore .dat extention legacy

* use get in show AbstractDFG

* Update NEWS

---------

Co-authored-by: Johannes Terblanche <[email protected]>

Author: Affie

NEWS.md

@@ -1,5 +1,11 @@
 Listing news on any major breaking changes in DFG.  For regular changes, see integrated Github.com project milestones for DFG.
+
+# v0.24
+
+- Remove `FolderStore` `.dat` legacy extension. To upgrade a legacy FolderStore remove extention with something like: `foreach(f->mv(f,split(f,".")[1]), files)`
+
 # v0.23
+
 - save/loadDFG now users Tar.jl and CodecZlib.jl #351.
 - save/loadDFG now preserves meta fields #921.
 - Deprecate getNeighbors for listNeighbors.

src/DataBlobs/services/BlobStores.jl

@@ -190,10 +190,10 @@ function FolderStore(foldername::String; createfolder = true)
     return FolderStore{Vector{UInt8}}(:default_folder_store, foldername)
 end
 
-blobfilename(store::FolderStore, blobId::UUID) = joinpath(store.folder, "$blobId.dat")
+blobfilename(store::FolderStore, blobId::UUID) = joinpath(store.folder, string(blobId))
 
 function getBlob(store::FolderStore{T}, blobId::UUID) where {T}
-    blobfilename = joinpath(store.folder, "$blobId.dat")
+    blobfilename = joinpath(store.folder, string(blobId))
     if isfile(blobfilename)
         open(blobfilename) do f
             return read(f)
@@ -204,7 +204,7 @@ function getBlob(store::FolderStore{T}, blobId::UUID) where {T}
 end
 
 function addBlob!(store::FolderStore{T}, blobId::UUID, data::T) where {T}
-    blobfilename = joinpath(store.folder, "$blobId.dat")
+    blobfilename = joinpath(store.folder, string(blobId))
     if isfile(blobfilename)
         throw(KeyError("Key '$blobId' blob already exists."))
     else
@@ -217,7 +217,7 @@ function addBlob!(store::FolderStore{T}, blobId::UUID, data::T) where {T}
 end
 
 function updateBlob!(store::FolderStore{T}, blobId::UUID, data::T) where {T}
-    blobfilename = joinpath(store.folder, "$blobId.dat")
+    blobfilename = joinpath(store.folder, string(blobId))
     if !isfile(blobfilename)
         @warn "Key '$blobId' doesn't exist."
     else
@@ -229,7 +229,7 @@ function updateBlob!(store::FolderStore{T}, blobId::UUID, data::T) where {T}
 end
 
 function deleteBlob!(store::FolderStore{T}, blobId::UUID) where {T}
-    blobfilename = joinpath(store.folder, "$blobId.dat")
+    blobfilename = joinpath(store.folder, string(blobId))
 
     data = getBlob(store, blobId)
     rm(blobfilename)
@@ -238,7 +238,7 @@ end
 
 #hasBlob or existsBlob?
 function hasBlob(store::FolderStore, blobId::UUID)
-    blobfilename = joinpath(store.folder, "$blobId.dat")
+    blobfilename = joinpath(store.folder, string(blobId))
     return isfile(blobfilename)
 end
 

src/services/CustomPrinting.jl

@@ -209,10 +209,10 @@ end
 
 function Base.show(io::IO, dfg::AbstractDFG)
     summary(io, dfg)
-    println(io, "\n  UserLabel: ", dfg.userLabel)
-    println(io, "  RobotLabel: ", dfg.robotLabel)
-    println(io, "  SessionLabel: ", dfg.sessionLabel)
-    println(io, "  Description: ", dfg.description)
+    println(io, "\n  UserLabel: ", getUserLabel(dfg))
+    println(io, "  RobotLabel: ", getRobotLabel(dfg))
+    println(io, "  SessionLabel: ", getSessionLabel(dfg))
+    println(io, "  Description: ", getDescription(dfg))
     println(io, "  Nr variables: ", length(ls(dfg)))
     println(io, "  Nr factors: ", length(lsf(dfg)))
     println(io, "  User Data: ", keys(getUserData(dfg)))