Skip to content

Commit 5cbec78

Browse files
authored
Merge pull request #905 from JuliaRobotics/22Q4/enh/904
add detail kw to getVariables
2 parents 9afbff0 + ebc3f13 commit 5cbec78

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/GraphsDFG/services/GraphsDFG.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ function deleteFactor!(dfg::GraphsDFG, label::Symbol; suppressGetFactor::Bool=fa
155155
return factor
156156
end
157157

158-
function getVariables(dfg::GraphsDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0)
158+
function getVariables(dfg::GraphsDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0, detail=nothing)
159159

160160
# variables = map(v -> v.dfgNode, filter(n -> n.dfgNode isa DFGVariable, vertices(dfg.g)))
161161
variables = collect(values(dfg.g.variables))

src/LightDFG/services/LightDFG.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ function deleteFactor!(dfg::LightDFG, label::Symbol; suppressGetFactor::Bool=fal
155155
return factor
156156
end
157157

158-
function getVariables(dfg::LightDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0)
158+
function getVariables(dfg::LightDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0, detail=nothing)
159159

160160
# variables = map(v -> v.dfgNode, filter(n -> n.dfgNode isa DFGVariable, vertices(dfg.g)))
161161
variables = collect(values(dfg.g.variables))

src/Neo4jDFG/services/Neo4jDFG.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ end
384384
# Alias
385385
deleteFactor!(dfg::Neo4jDFG, factor::DFGFactor; suppressGetFactor::Bool=false) = deleteFactor!(dfg, factor.label, suppressGetFactor=suppressGetFactor)
386386

387-
function getVariables(dfg::Neo4jDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0)::Vector{DFGVariable}
387+
function getVariables(dfg::Neo4jDFG, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0, detail=nothing)::Vector{DFGVariable}
388388
variableIds = listVariables(dfg, regexFilter, tags=tags, solvable=solvable)
389389
# TODO: Optimize to use tags in query here!
390390
variables = map(vId->getVariable(dfg, vId), variableIds)

src/services/AbstractDFG.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ List the DFGVariables in the DFG.
295295
Optionally specify a label regular expression to retrieves a subset of the variables.
296296
Tags is a list of any tags that a node must have (at least one match).
297297
"""
298-
function getVariables(dfg::G, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0) where G <: AbstractDFG
298+
function getVariables(dfg::G, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0, detail=nothing) where G <: AbstractDFG
299299
error("getVariables not implemented for $(typeof(dfg))")
300300
end
301301

0 commit comments

Comments
 (0)