Skip to content

Commit 683a7d5

Browse files
committed
better comments
1 parent 9c5356b commit 683a7d5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/services/Serialization.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,8 @@ function unpackVariable(dfg::G,
231231
Symbol.(packedProps["tags"])
232232
end
233233

234+
# FIXME, drop nested packing, see DFG #867
234235
ppeDict = if unpackPPEs && haskey(packedProps,"ppesDict")
235-
# FIXME, drop nested packing, see DFG #867
236236
JSON2.read(packedProps["ppeDict"], Dict{Symbol, MeanMaxPPE})
237237
elseif unpackPPEs && haskey(packedProps,"ppes") && packedProps["ppes"] isa AbstractVector
238238
# these different cases are not well covered in tests, but first fix #867
@@ -255,13 +255,13 @@ function unpackVariable(dfg::G,
255255
isnothing(variableType) && error("Cannot deserialize variableType '$variableTypeString' in variable '$label'")
256256
pointType = getPointType(variableType)
257257

258+
# FIXME, drop nested packing, see DFG #867
258259
solverData = if unpackSolverData && haskey(packedProps, "solverDataDict")
259260
packed = JSON2.read(packedProps["solverDataDict"], Dict{String, PackedVariableNodeData})
260261
Dict{Symbol, VariableNodeData{variableType, pointType}}(Symbol.(keys(packed)) .=> map(p -> unpackVariableNodeData(dfg, p), values(packed)))
261262
elseif unpackPPEs && haskey(packedProps,"solverData") && packedProps["solverData"] isa AbstractVector
262263
solverdict = Dict{Symbol, VariableNodeData{variableType, pointType}}()
263264
for sd in packedProps["solverData"]
264-
# _type = haskey(sd, "_type") ? sd["_type"] : "DistributedFactorGraphs.PackedVariableNodeData"
265265
solverdict[Symbol(sd["solveKey"])] = _unpackVariableNodeData(dfg, sd)
266266
end
267267
solverdict

0 commit comments

Comments
 (0)