Skip to content

Commit 6f7c5c0

Browse files
committed
Cleanup, retaining _internalId on variables and factors because of summary
1 parent 4111823 commit 6f7c5c0

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

src/LightDFG/services/LightDFG.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ function addFactor!(dfg::LightDFG, variables::Vector{V}, factor::F)::Bool where
7070
# end
7171
# end
7272

73-
#NOTE Internal ID always set to zero as it is not needed?
74-
# factor._internalId = 0
75-
7673
variableLabels = map(v->v.label, variables)
7774

7875
factor._variableOrderSymbols = copy(variableLabels)
@@ -90,7 +87,6 @@ function addFactor!(dfg::LightDFG, variableLabels::Vector{Symbol}, factor::F)::B
9087
if haskey(dfg.g.factors, factor.label)
9188
error("Factor '$(factor.label)' already exists in the factor graph")
9289
end
93-
# factor._internalId = 0
9490

9591
factor._variableOrderSymbols = variableLabels
9692

src/SymbolDFG/services/SymbolDFG.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ function addFactor!(dfg::SymbolDFG, variableLabels::Vector{Symbol}, factor::DFGF
8686
if haskey(dfg.g.factors, factor.label)
8787
error("Factor '$(factor.label)' already exists in the factor graph")
8888
end
89-
# factor._internalId = 0
9089

9190
factor._variableOrderSymbols = variableLabels
9291

0 commit comments

Comments
 (0)