Merge pull request #903 from JuliaRobotics/22Q4/enh/bettererrmsg

Better error message on getSolverData

Author: dehann

src/services/DFGVariable.jl

@@ -417,7 +417,7 @@ Retrieve solver data structure stored in a variable.
 """
 function getSolverData(v::DFGVariable, key::Symbol=:default)
     #TODO this does not fit in with some of the other error behaviour. but its used so added @error
-    vnd =  haskey(v.solverDataDict, key) ? v.solverDataDict[key] : (@error "Variable does not have solver data $(key)"; nothing)
+    vnd =  haskey(v.solverDataDict, key) ? v.solverDataDict[key] : (@error "Variable $(getLabel(v)) does not have solver data $(key)"; nothing)
     return vnd
 end
 

test/testBlocks.jl

@@ -1117,7 +1117,7 @@ function testGroup!(fg, v1, v2, f0, f1)
         #solver data is initialized
         @test !isInitialized(fg, :a)
         @test !isInitialized(v2)
-        @test @test_logs (:error, r"Variable does not have solver data") !isInitialized(v2, :second)
+        @test @test_logs (:error, r"does not have solver data") !isInitialized(v2, :second)
 
         # solvables
         @test getSolvable(v1) == 0