put back deprecated for a bit longer and backward compat for loadDFG

Author: Affie

src/Deprecated.jl

@@ -1,13 +1,57 @@
 ##==============================================================================
 # deprecation staging area
 ##==============================================================================
+##==============================================================================
+## Deprecated in v0.9 Remove in the v0.10 cycle
+##==============================================================================
+
+# temporary promote with warning
+Base.promote_rule(::Type{DateTime}, ::Type{ZonedDateTime}) = DateTime
+function Base.convert(::Type{DateTime}, ts::ZonedDateTime)
+    @warn "DFG now uses ZonedDateTime, temporary promoting and converting to DateTime local time"
+    return DateTime(ts, Local)
+end
+
+@deprecate listSolvekeys(x...) listSolveKeys(x...)
+
+
+
+export InferenceType
+export FunctorSingleton, FunctorPairwise, FunctorPairwiseMinimize
+
+abstract type InferenceType end
+
+# These will become AbstractPrior, AbstractRelativeFactor, and AbstractRelativeFactorMinimize in 0.9.
+abstract type FunctorSingleton <: FunctorInferenceType end
+abstract type FunctorPairwise <: FunctorInferenceType end
+abstract type FunctorPairwiseMinimize <: FunctorInferenceType end
+
+# I don't know how to deprecate this, any suggestions?
+const AbstractBigDataEntry = AbstractDataEntry
+
+@deprecate GeneralBigDataEntry(args...; kwargs...) GeneralDataEntry(args...; kwargs...)
+@deprecate MongodbBigDataEntry(args...)  MongodbDataEntry(args...)
+@deprecate FileBigDataEntry(args...)  FileDataEntry(args...)
+
+@deprecate getBigData(args...) getDataBlob(args...)
+@deprecate addBigData!(args...) addDataBlob!(args...)
+@deprecate updateBigData!(args...) updateDataBlob!(args...)
+@deprecate deleteBigData!(args...) deleteDataBlob!(args...)
+@deprecate listStoreEntries(args...) listDataBlobs(args...)
+@deprecate hasBigDataEntry(args...) hasDataEntry(args...)
+
+@deprecate getBigDataEntry(args...) getDataEntry(args...)
+@deprecate addBigDataEntry!(args...)  addDataEntry!(args...)
+@deprecate updateBigDataEntry!(args...) updateDataEntry!(args...)
+@deprecate deleteBigDataEntry!(args...) deleteDataEntry!(args...)
+@deprecate getBigDataKeys(args...) listDataEntries(args...)
+@deprecate getBigDataEntries(args...) getDataEntries(args...)
+@deprecate getDataEntryElement(args...) getDataEntryBlob(args...)
 
 ##==============================================================================
 ## Remove in 0.11
 ##==============================================================================
 
-@deprecate listSolvekeys(x...; kwargs...) listSolveKeys(x...;kwargs...)
-
 @deprecate addVariableSolverData!(dfg::AbstractDFG, variablekey::Symbol, vnd::VariableNodeData, solveKey::Symbol) addVariableSolverData!(dfg, variablekey, vnd)
 
 @deprecate updatePPE!(dfg::AbstractDFG, variablekey::Symbol, ppe::AbstractPointParametricEst, ppekey::Symbol) updatePPE!(dfg, variablekey, ppe)

src/services/Serialization.jl

@@ -190,7 +190,9 @@ function unpackVariableNodeData(dfg::G, d::PackedVariableNodeData)::VariableNode
 
   @debug "Dispatching conversion packed variable -> variable for type $(string(d.softtype))"
   # Figuring out the softtype
-  st =  getTypeFromSerializationModule(d.softtype)
+  # TODO deprecated remove in v0.11 - for backward compatibility for saved softtypes. 
+  ststring = string(split(d.softtype, "(")[1])
+  st =  getTypeFromSerializationModule(ststring)
   isnothing(st) && error("The variable doesn't seem to have a softtype. It needs to set up with an InferenceVariable from IIF. This will happen if you use DFG to add serialized variables directly and try use them. Please use IncrementalInference.addVariable().")
 
   return VariableNodeData{st}(M3,M4, d.BayesNetOutVertIDs,