Merge pull request #175 from JuliaRobotics/hotfix/getData_solverData

Hotfix cherry pick getData->solverData

Author: GearsAD

src/CloudGraphsDFG/services/CloudGraphsDFG.jl

@@ -258,7 +258,7 @@ function getFactor(dfg::CloudGraphsDFG, factorId::Int64)::DFGFactor
     factor = dfg.rebuildFactorMetadata!(dfg, factor)
     # GUARANTEED never to bite us in the future...
     # ... TODO: refactor if changed: https://github.com/JuliaRobotics/IncrementalInference.jl/issues/350
-    getData(factor).fncargvID = _variableOrderSymbols
+    solverData(factor).fncargvID = _variableOrderSymbols
 
     # Add to cache
     push!(dfg.factorCache, factor.label=>factor)

src/FileDFG/services/FileDFG.jl

@@ -71,7 +71,7 @@ function loadDFG(folder::String, iifModule, dfgLoadInto::G=GraphsDFG{NoSolverPar
     # PATCH - To update the fncargvID for factors, it's being cleared somewhere in rebuildFactorMetadata.
     # TEMPORARY
     # TODO: Remove
-    map(f->getData(f).fncargvID = f._variableOrderSymbols, getFactors(dfgLoadInto))
+    map(f->solverData(f).fncargvID = f._variableOrderSymbols, getFactors(dfgLoadInto))
 
 
     return dfgLoadInto

src/services/AbstractDFG.jl

@@ -547,7 +547,7 @@ isFactor(dfg::G, sym::Symbol) where G <: AbstractDFG = hasFactor(dfg, sym)
 Return reference to the user factor in `<:AbstractDFG` identified by `::Symbol`.
 """
 getFactorFunction(fcd::GenericFunctionNodeData) = fcd.fnc.usrfnc!
-getFactorFunction(fc::DFGFactor) = getFactorFunction(getData(fc))
+getFactorFunction(fc::DFGFactor) = getFactorFunction(solverData(fc))
 function getFactorFunction(dfg::G, fsym::Symbol) where G <: AbstractDFG
   getFactorFunction(getFactor(dfg, fsym))
 end