remove v0.6 deprecations (#324)

* remove v0.6 deprecations

* export const DFG = DistributedFactorGraphs

Author: Affie

src/Deprecated.jl

@@ -2,38 +2,6 @@
 # deprecation staging area
 ##==============================================================================
 
-#TODO look what should already be removed
-
-##==============================================================================
-## Remove in 0.6.0 or 0.6.1?
-##==============================================================================
-
-@deprecate getfnctype(args...) getFactorType(args...)
-
-@deprecate getEstimate(v::VariableDataLevel1, key::Symbol=:default) getVariablePPE(v, key)
-
-@deprecate estimate(v::VariableDataLevel1, key::Symbol=:default) getVariablePPE(v, key)
-
-@deprecate getEstimates(v::VariableDataLevel1) getPPEDict(v)
-
-@deprecate estimates(v::VariableDataLevel1) getPPEDict(v)
-
-@deprecate softtype(v::VariableDataLevel1) getSofttype(v)
-
-@deprecate label(v::DataLevel0) getLabel(v)
-
-@deprecate tags(v::DataLevel0) getTags(v)
-
-@deprecate getData(v::DFGVariable; solveKey::Symbol=:default) getSolverData(v, solveKey)
-
-@deprecate setSolverData(v::DFGVariable, data::VariableNodeData, key::Symbol=:default) setSolverData!(v, data, key)
-
-@deprecate data(f::DFGFactor) getSolverData(f)
-
-
-@deprecate getData(f::DFGFactor) getSolverData(f)
-
-
 ##==============================================================================
 ## Remove in 0.7
 ##==============================================================================
@@ -190,3 +158,7 @@ function buildSubgraphFromLabels(dfg::G,
 end
 
 @deprecate sortVarNested(vars::Vector{Symbol}) sortDFG(vars)
+
+
+#NOTE This one is still used in IIF so maybe leave a bit longer
+@deprecate getfnctype(args...) getFactorType(args...)

src/DistributedFactorGraphs.jl

@@ -30,7 +30,8 @@ using SparseArrays
 ##==============================================================================
 # Exports
 ##==============================================================================
-
+const DFG = DistributedFactorGraphs
+export DFG
 ##------------------------------------------------------------------------------
 ## DFG
 ##------------------------------------------------------------------------------

src/services/DFGFactor.jl

@@ -139,7 +139,7 @@ Return `::Bool` on whether given factor `fc::Symbol` is a prior in factor graph
 """
 function isPrior(dfg::G, fc::Symbol)::Bool where G <: AbstractDFG
   fco = getFactor(dfg, fc)
-  getfnctype(fco) isa FunctorSingleton
+  getFactorType(fco) isa FunctorSingleton
 end
 
 

test/iifInterfaceTests.jl

@@ -189,7 +189,7 @@ end
     @test getVariablePPEs(v1) == v1.ppeDict
     @test_throws Exception DistributedFactorGraphs.getVariablePPE(v1, :notfound)
     @test solverData(v1) === v1.solverDataDict[:default]
-    @test getData(v1) === v1.solverDataDict[:default]
+    @test getSolverData(v1) === v1.solverDataDict[:default]
     @test solverData(v1, :default) === v1.solverDataDict[:default]
     @test getSolverDataDict(v1) == v1.solverDataDict
     @test getInternalId(v1) == v1._internalId

test/testBlocks.jl

@@ -217,12 +217,8 @@ function DFGVariableSCA()
     #no accessors on BigData, only CRUD
 
     #deprecated
-    @test @test_deprecated getData(v1) === v1.solverDataDict[:default]
     @test @test_deprecated solverData(v1, :default) === v1.solverDataDict[:default]
 
-    #what TODO
-    # @test_deprecated setSolverData()
-    # setSolverData!()
 
     # #TODO sort out
     # getPPEs
@@ -302,7 +298,6 @@ function  DFGFactorSCA()
 
     # Deprecated functions
     @test @test_deprecated solverData(f1) === f1.solverData
-    @test @test_deprecated getData(f1) === f1.data
 
     # create f0 here for a later timestamp
     f0 = DFGFactor(:af1, [:a], gfnd_prior, tags = Set([:PRIOR]))
@@ -591,7 +586,6 @@ function  VSDTestBlock!(fg, v1)
 
     #FIXME copied from lower
     @test getSolverData(v1) === v1.solverDataDict[:default]
-    @test @test_logs (:warn, r"[Dd]eprecate") getData(v1) === v1.solverDataDict[:default]
     @test @test_logs (:warn, r"[Dd]eprecate") solverData(v1, :default) === v1.solverDataDict[:default]
 
     # Add new VND of type ContinuousScalar to :x0