Skip to content

Commit 8b33bce

Browse files
authored
Merge pull request #445 from JuliaRobotics/hotfix/2Q20/paramsdispatch
change to params instead (similar to before)
2 parents c14a6e6 + 5d792fa commit 8b33bce

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/services/AbstractDFG.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ getSolverParams(dfg::AbstractDFG) = dfg.solverParams
5757
5858
Method must be overloaded by the user for Serialization to work. E.g. IncrementalInference uses `CommonConvWrapper <: FactorOperationalMemory`.
5959
"""
60-
getFactorOperationalMemoryType(dummy) = error("Please define this function getFactorOperationalMemoryType for your usecase, e.g. = `IIF.CommonConvWrapper <: FactorOperationalMemory`")
60+
getFactorOperationalMemoryType(dummy) = error("Please extend your workspace with function getFactorOperationalMemoryType(<:AbstractParams) for your usecase, e.g. IncrementalInference uses `CommonConvWrapper <: FactorOperationalMemory`")
61+
getFactorOperationalMemoryType(dfg::AbstractDFG) = getFactorOperationalMemoryType(getSolverParams(dfg))
6162

6263

6364
##------------------------------------------------------------------------------

test/consolInterfaceDev.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ using Dates
77
using UUIDs
88
# using IncrementalInference
99

10-
## must overload the function
11-
import DistributedFactorGraphs: getFactorOperationalMemoryType
12-
# DF, dropping DFG. so that Main context is used and can be overridden by IIF.getFac...Type
13-
getFactorOperationalMemoryType(::CloudGraphsDFG) = TestCCW
14-
1510

1611
include("testBlocks.jl")
1712

0 commit comments

Comments
 (0)