Skip to content

Commit 8b75810

Browse files
authored
Merge pull request #1042 from JuliaRobotics/23Q3/jl10/fixtests
fix tests for JL 1.10
2 parents bde8a13 + 7b4a745 commit 8b75810

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fail-fast: false
1919
matrix:
2020
version:
21-
- '1.9'
21+
- '~1.10.0-0'
2222
- 'nightly'
2323
os:
2424
- ubuntu-latest

test/iifInterfaceTests.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ end
129129
# Existence
130130
@test exists(dfg, :a) == true
131131
@test exists(dfg, v1) == true
132+
@show exists(dfg, :nope)
132133
@test exists(dfg, :nope) == false
133134
# isFactor and isVariable
134135
@test isFactor(dfg, f1.label)
@@ -139,6 +140,7 @@ end
139140
@test !isFactor(dfg, :doesntexist)
140141

141142
@test issetequal([:a, :b], listVariables(dfg))
143+
@show listFactors(dfg)
142144
@test issetequal([:abf1], listFactors(dfg))
143145

144146
# @test @test_deprecated getVariableIds(dfg) == listVariables(dfg)
@@ -151,7 +153,7 @@ end
151153
@test !isPrior(dfg, :abf1) # f1 is not a prior
152154
@test lsfPriors(dfg) == []
153155
#FIXME don't know what it is supposed to do
154-
@test_broken lsfTypes(dfg)
156+
@test 0 < length( lsfTypes(dfg) )
155157

156158
@test ls(dfg, LinearRelative) == [:abf1]
157159
@test lsf(dfg, LinearRelative) == [:abf1]
@@ -161,7 +163,7 @@ end
161163
@test getVariableType(dfg, :a) isa Position{1}
162164

163165
#TODO what is lsTypes supposed to return?
164-
@test_broken lsTypes(dfg)
166+
@test 0 < length( lsTypes(dfg) )
165167

166168
@test issetequal(ls(dfg, Position{1}), [:a, :b])
167169
@test issetequal(lsWho(dfg, :Position), [:a, :b])

0 commit comments

Comments
 (0)