dehann's request: verbose on orphan warn

Author: Affie

src/services/AbstractDFG.jl

@@ -848,7 +848,13 @@ function getSubgraph(dfg::G,
     return addToDFG
 end
 
-
+"""
+    $(SIGNATURES)
+Build a deep subgraph copy from the DFG given a list of variables and factors and an optional distance.
+Note: Orphaned factors (where the subgraph does not contain all the related variables) are not returned.
+Dev Notes
+- Bulk vs node for node: a list of labels are compiled and the sugraph is copied in bulk. 
+"""
 function buildSubgraph(::Type{G}, dfg::AbstractDFG, variableFactorLabels::Vector{Symbol}, distance::Int=0; solvable::Int=0, kwargs...) where G <: AbstractDFG
 
     # find neighbors at distance to add

src/services/copyFunctions.jl

@@ -6,14 +6,20 @@ Orphaned factors are not added.
 Set `overwriteDest` to overwrite existing variables and factors in the destination DFG.
 NOTE: copyGraphMetadata not supported yet.
 """
-function copyGraph!(destDFG::AbstractDFG, sourceDFG::AbstractDFG, variableFactorLabels::Vector{Symbol}; copyGraphMetadata::Bool=false, overwriteDest::Bool=false, deepcopyNodes::Bool=false)
+function copyGraph!(destDFG::AbstractDFG,
+                    sourceDFG::AbstractDFG,
+                    variableFactorLabels::Vector{Symbol};
+                    copyGraphMetadata::Bool=false,
+                    overwriteDest::Bool=false,
+                    deepcopyNodes::Bool=false,
+                    verbose::Bool = true)
     # Split into variables and factors
     sourceVariables = map(vId->getVariable(sourceDFG, vId), intersect(listVariables(sourceDFG), variableFactorLabels))
     sourceFactors = map(fId->getFactor(sourceDFG, fId), intersect(listFactors(sourceDFG), variableFactorLabels))
     if length(sourceVariables) + length(sourceFactors) != length(variableFactorLabels)
-        rem = symdiff(map(v->v.label, sourceVariables), variableFactorLabels)
-        rem = symdiff(map(f->f.label, sourceFactors), variableFactorLabels)
-        error("Cannot copy because cannot find the following nodes in the source graph: $rem")
+        remv = setdiff(map(v->v.label, sourceVariables), variableFactorLabels)
+        remf = setdiff(map(f->f.label, sourceFactors), variableFactorLabels)
+        error("Cannot copy because cannot find the following nodes in the source graph: $remv, $remf")
     end
 
     # Now we have to add all variables first,
@@ -48,7 +54,7 @@ function copyGraph!(destDFG::AbstractDFG, sourceDFG::AbstractDFG, variableFactor
             else
                 error("Factor $(factor.label) already exists in destination graph!")
             end
-        else
+        elseif verbose
             @warn "Factor $(factor.label) will be an orphan in the destination graph, and therefore not added."
         end
     end
@@ -61,6 +67,7 @@ function copyGraph!(destDFG::AbstractDFG, sourceDFG::AbstractDFG, variableFactor
     return nothing
 end
 
+
 function deepcopyGraph!(destDFG::AbstractDFG,
                         sourceDFG::AbstractDFG,
                         variableFactorLabels::Vector{Symbol} = union(ls(sourceDFG), lsf(sourceDFG));