Less allocs in GraphsDFG ls and lsf (#1018)

Co-authored-by: Johannes Terblanche <[email protected]>

Author: Affie

src/GraphsDFG/FactorGraphs/FactorGraphs.jl

@@ -150,6 +150,9 @@ function rem_vertex!(g::FactorGraph{T,V,F}, v::Integer) where {T,V,F}
     label = g.labels[v]
     delete!(g.variables, label)
     delete!(g.factors, label)
+    
+    OrderedCollections.rehash!(g.variables)
+    OrderedCollections.rehash!(g.factors)
 
     if v != lastv
         g.labels[v] = g.labels[lastv] #lastSym

src/GraphsDFG/services/GraphsDFG.jl

@@ -151,7 +151,7 @@ function deleteFactor!(dfg::GraphsDFG, label::Symbol; suppressGetFactor::Bool=fa
         error("Factor label '$(label)' does not exist in the factor graph")
     end
     factor = dfg.g.factors[label]
-    variable = rem_vertex!(dfg.g,  dfg.g.labels[label])
+    rem_vertex!(dfg.g,  dfg.g.labels[label])
     return factor
 end
 
@@ -178,7 +178,7 @@ function listVariables(dfg::GraphsDFG, regexFilter::Union{Nothing, Regex}=nothin
     if length(tags) > 0
         return map(v -> v.label, getVariables(dfg, regexFilter, tags=tags, solvable=solvable))
     else
-        variables = collect(keys(dfg.g.variables))
+        variables = copy(dfg.g.variables.keys)
         regexFilter !== nothing && (variables = filter(v -> occursin(regexFilter, String(v)), variables))
         solvable != 0 && (variables = filter(vId -> _isSolvable(dfg, vId, solvable), variables))
         return variables::Vector{Symbol}
@@ -206,7 +206,7 @@ function listFactors(dfg::GraphsDFG, regexFilter::Union{Nothing, Regex}=nothing;
     if length(tags) > 0
         return map(v -> v.label, getFactors(dfg, regexFilter, tags=tags, solvable=solvable))
     end
-    factors = collect(keys(dfg.g.factors))
+    factors = copy(dfg.g.factors.keys)
     if regexFilter != nothing
         factors = filter(f -> occursin(regexFilter, String(f)), factors)
     end