Add & test more packedVariable blobEntry functions

Author: Affie

src/DataBlobs/services/BlobEntry.jl

@@ -79,6 +79,13 @@ function getBlobEntry(var::AbstractDFGVariable, key::Symbol)
     return var.dataDict[key]
 end
 
+function getBlobEntry(var::PackedVariable, key::Symbol)   
+    if !hasBlobEntry(var, key)
+        throw(KeyError("No dataEntry label $(key) found in variable $(getLabel(var)). Available keys: $(keys(var.dataDict))"))
+    end    
+    return var.blobEntries[findfirst(x->x.label == key, var.blobEntries)]
+end
+
 function getBlobEntry(var::AbstractDFGVariable, blobId::UUID)
     for (k,v) in var.dataDict
         if blobId in [v.originId, v.blobId]
@@ -204,6 +211,9 @@ Does a blob entry (element) exist with `blobLabel`.
 """
 hasBlobEntry(var::AbstractDFGVariable, blobLabel::Symbol) = haskey(var.dataDict, blobLabel)
 
+function hasBlobEntry(var::PackedVariable, label::Symbol)
+    return label in getproperty.(var.blobEntries, :label)
+end
 
 """
     $(SIGNATURES)
@@ -271,6 +281,10 @@ function listBlobEntries(var::AbstractDFGVariable)
     collect(keys(var.dataDict))
 end
 
+function listBlobEntries(var::PackedVariable)
+    return getproperty.(var.blobEntries, :label)
+end
+
 function listBlobEntries(dfg::AbstractDFG, label::Symbol)
     # !isVariable(dfg, label) && return nothing
     listBlobEntries(getVariable(dfg, label))

test/testBlocks.jl

@@ -943,6 +943,16 @@ function  DataEntriesTestBlock!(fg, v2)
     @test deleteBlobEntry!(fg, :a, :key2) == de2_update
     @test listBlobEntries(v1) == Symbol[]
     deleteBlobEntry!(fg, :b, :key2)
+
+    # packed variable data entries
+    pacv = packVariable(v1)
+    @test addBlobEntry!(pacv, de1) == de1
+    @test hasBlobEntry(pacv, :key1)
+    @test deepcopy(de1) == getBlobEntry(pacv, :key1)
+    @test getBlobEntries(pacv) == [deepcopy(de1)]
+    @test issetequal(listBlobEntries(pacv), [:key1])
+    # @test deleteBlobEntry!(pacv, de1) == de1
+
 end
 
 function blobsStoresTestBlock!(fg)