Updated and added test to iifInterfaceTests.jl

Author: GearsAD

test/iifInterfaceTests.jl

@@ -405,6 +405,13 @@ end
     # Only returns x1 and x2
     @test symdiff([:x1, :x1x2f1, :x2], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
 
+    # DFG issue #201 Test include orphan factors with filtering - should only return x7 with solvable=1
+    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x7x8f1), 1, true, solvable=0)
+    @test symdiff([:x7, :x8, :x7x8f1], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
+    # Filter - always returns the node you start at but filters around that.
+    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x7x8f1), 1, true, solvable=1)
+    @test symdiff([:x7x8f1, :x7], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
+
     # DFG issue #95 - confirming that getSubgraphAroundNode retains order
     # REF: https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/95
     for fId in getVariableIds(dfg)

test/interfaceTests.jl

@@ -1,5 +1,3 @@
-# using DistributedFactorGraphs, Test
-# testDFGAPI = LightDFG
 dfg = testDFGAPI{NoSolverParams}()
 
 #add types for softtypes
@@ -357,12 +355,11 @@ end
     @test symdiff([:x1, :x1x2f1, :x2], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
 
     # DFG issue #201 Test include orphan factors with filtering - should only return x7 with solvable=1
-    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x6x7f1), 1, true, solvable=0)
-    @test symdiff([:x6, :x7, :x6x7f1], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
+    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x7x8f1), 1, true, solvable=0)
+    @test symdiff([:x7, :x8, :x7x8f1], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
     # Filter - always returns the node you start at but filters around that.
-    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x6x7f1), 1, true, solvable=1)
-    @test symdiff([:x6x7f1, :x7], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
-
+    dfgSubgraph = getSubgraphAroundNode(dfg, getFactor(dfg, :x7x8f1), 1, true, solvable=1)
+    @test symdiff([:x7x8f1, :x7], [ls(dfgSubgraph)..., lsf(dfgSubgraph)...]) == []
 
     # DFG issue #95 - confirming that getSubgraphAroundNode retains order
     # REF: https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/95