Rest of the functions

Author: GearsAD

src/DistributedFactorGraphs.jl

@@ -22,7 +22,7 @@ export DFGNode, DFGVariable, DFGFactor, AbstractDFGVariable, AbstractDFGFactor
 export InferenceType, PackedInferenceType, FunctorInferenceType, InferenceVariable, ConvolutionObject
 export FunctorSingleton, FunctorPairwise, FunctorPairwiseMinimize
 export getMaxPPE, getMeanPPE, getSuggestedPPE
-export label, timestamp, tags, estimates, estimate, data, softtype, solverData, getData, solverDataDict, setSolverData, internalId, smallData, bigData
+export label, timestamp, setTimestamp!, tags, setTags!, estimates, estimate, data, softtype, solverData, getData, solverDataDict, setSolverData, setSolverData!, internalId, smallData, setSmallData!, bigData
 export DFGVariableSummary, DFGFactorSummary, AbstractDFGSummary
 
 #Skeleton types

src/entities/DFGFactor.jl

@@ -87,12 +87,21 @@ $SIGNATURES
 Return the label for a factor.
 """
 label(f::FactorDataLevel0) = f.label
+
 """
 $SIGNATURES
 
 Return the tags for a variable.
 """
 tags(f::FactorDataLevel0) = f.tags
+
+"""
+$SIGNATURES
+
+Set the tags for a factor.
+"""
+setTag!s(f::FactorDataLevel0, tags::Vector{Symbol}) = f.tags = tags
+
 """
 $SIGNATURES
 

src/entities/DFGVariable.jl

@@ -207,9 +207,9 @@ tags(v::VariableDataLevel0) = v.tags
 """
 $SIGNATURES
 
-Get the small data for a variable.
+Set the tags for a variable.
 """
-setTags(v::VariableDataLevel0, tags::Vector{Symbol}) = v.tags = tags
+setTags!(v::VariableDataLevel0, tags::Vector{Symbol}) = v.tags = tags
 
 """
     $SIGNATURES
@@ -221,9 +221,9 @@ timestamp(v::VariableDataLevel1) = v.timestamp
 """
 $SIGNATURES
 
-Get the small data for a variable.
+Set the timestamp for a variable.
 """
-setTimestamp(v::VariableDataLevel1, timestamp::DateTime) = v.timestamp = timestamp
+setTimestamp!(v::VariableDataLevel1, timestamp::DateTime) = v.timestamp = timestamp
 
 """
     $SIGNATURES
@@ -281,6 +281,13 @@ end
 Set solver data structure stored in a variable.
 """
 setSolverData(v::DFGVariable, data::VariableNodeData, key::Symbol=:default) = v.solverDataDict[key] = data
+"""
+    $SIGNATURES
+
+Set solver data structure stored in a variable.
+"""
+setSolverData!(v::DFGVariable, data::VariableNodeData, key::Symbol=:default) = setSolverData(v, data, key)
+
 """
     $SIGNATURES
 
@@ -298,9 +305,9 @@ smallData(v::DFGVariable) = v.smallData
 """
 $SIGNATURES
 
-Get the small data for a variable.
+Set the small data for a variable.
 """
-setSmallData(v::DFGVariable, smallData::String) = v.smallData = smallData
+setSmallData!(v::DFGVariable, smallData::String) = v.smallData = smallData
 
 # Todo: Complete this.
 bigData(v::DFGVariable) = v.bigData

test/interfaceTests.jl

@@ -125,11 +125,22 @@ end
     f1Prime = deepcopy(f1)
     #updateFactor! returns the factor updated, so should be equal
     @test updateFactor!(dfg, f1Prime) == f1
+    # Revert
+    v1 = getVariable(dfg, v1.label)
+    f1 = getFactor(dfg, f1.label)
 
     # Accessors
     @test label(v1) == v1.label
     @test tags(v1) == v1.tags
+    testTags = [:ha, :ha23]
+    @test setTags!(v1, testTags) == testTags
+    @test tags(v1) == testTags
+
     @test timestamp(v1) == v1.timestamp
+    testTimestamp = now()
+    @test setTimestamp!(v1, testTimestamp) == testTimestamp
+    @test timestamp(v1) == testTimestamp
+
     @test estimates(v1) == v1.estimateDict
     @test estimate(v1, :notfound) == nothing
     @test solverData(v1) === v1.solverDataDict[:default]
@@ -144,6 +155,9 @@ end
 
     @test label(f1) == f1.label
     @test tags(f1) == f1.tags
+    @test setTags!(v1, testTags) == testTags
+    @test tags(v1) == testTags
+
     @test solverData(f1) == f1.data
     # Deprecated functions
     @test data(f1) == f1.data

test/runtests.jl

@@ -3,6 +3,7 @@ using GraphPlot # For plotting tests
 using Neo4j
 using DistributedFactorGraphs
 using Pkg
+using Dates
 
 ## To run the IIF tests, you need a local Neo4j with user/pass neo4j:test
 # To run a Docker image