fix #232

Author: dehann

src/DistributedFactorGraphs.jl

@@ -22,7 +22,8 @@ export DFGNode, DFGVariable, DFGFactor, AbstractDFGVariable, AbstractDFGFactor
 export InferenceType, PackedInferenceType, FunctorInferenceType, InferenceVariable, ConvolutionObject
 export FunctorSingleton, FunctorPairwise, FunctorPairwiseMinimize
 export getMaxPPE, getMeanPPE, getSuggestedPPE
-export label, timestamp, setTimestamp!, tags, setTags!, estimates, estimate, data, softtype, solverData, getData, solverDataDict, setSolverData, setSolverData!, internalId, smallData, setSmallData!, bigData
+export timestamp # DEPRECATED
+export label, getTimestamp, setTimestamp!, tags, setTags!, estimates, estimate, data, softtype, solverData, getData, solverDataDict, setSolverData, setSolverData!, internalId, smallData, setSmallData!, bigData
 export DFGVariableSummary, DFGFactorSummary, AbstractDFGSummary
 export addBigDataEntry!, getBigDataEntry, updateBigDataEntry!, deleteBigDataEntry!, getBigDataEntries, getBigDataKeys
 

src/entities/DFGFactor.jl

@@ -116,9 +116,21 @@ setTags!(f::FactorDataLevel0, tags::Vector{Symbol}) = f.tags = tags
 """
 $SIGNATURES
 
+Get the timestamp from a DFGFactor object.
+
+DEPRECATED -> use getTimestamp instead.
+"""
+function timestamp(v::FactorDataLevel1)
+  @warn "timestamp deprecated, use getTimestamp instead"
+  v.timestamp
+end
+
+"""
+$SIGNATURES
+
 Get the timestamp from a DFGFactor object.
 """
-timestamp(v::FactorDataLevel1) = v.timestamp
+getTimestamp(v::FactorDataLevel1) = v.timestamp
 
 """
 $SIGNATURES

src/entities/DFGVariable.jl

@@ -211,12 +211,24 @@ Set the tags for a variable.
 """
 setTags!(v::VariableDataLevel0, tags::Vector{Symbol}) = v.tags = tags
 
+"""
+    $SIGNATURES
+
+Return the timestamp for a variable.
+
+DEPRECATED -> use getTimestamp instead.
+"""
+function timestamp(v::VariableDataLevel1)
+    @warn "timestamp is deprecated, use getTimestamp instead"
+    v.timestamp
+end
+
 """
     $SIGNATURES
 
 Return the timestamp for a variable.
 """
-timestamp(v::VariableDataLevel1) = v.timestamp
+getTimestamp(v::VariableDataLevel1) = v.timestamp
 
 """
 $SIGNATURES

test/LightDFGSummaryTypes.jl

@@ -98,7 +98,7 @@ end
     @test tags(v1) == v1.tags
 
     if VARTYPE == DFGVariableSummary
-        @test timestamp(v1) == v1.timestamp
+        @test getTimestamp(v1) == v1.timestamp
         @test estimates(v1) == v1.estimateDict
         @test estimate(v1, :notfound) == nothing
         @test softtype(v1) == :Pose2

test/iifInterfaceTests.jl

@@ -151,7 +151,7 @@ end
     # Accessors
     @test label(v1) == v1.label
     @test tags(v1) == v1.tags
-    @test timestamp(v1) == v1.timestamp
+    @test getTimestamp(v1) == v1.timestamp
     @test estimates(v1) == v1.estimateDict
     @test DistributedFactorGraphs.estimate(v1, :notfound) == nothing
     @test solverData(v1) === v1.solverDataDict[:default]

test/interfaceTests.jl

@@ -136,15 +136,15 @@ end
     @test setTags!(v1, testTags) == testTags
     @test tags(v1) == testTags
 
-    @test timestamp(v1) == v1.timestamp
+    @test getTimestamp(v1) == v1.timestamp
     testTimestamp = now()
     @test setTimestamp!(v1, testTimestamp) == testTimestamp
-    @test timestamp(v1) == testTimestamp
+    @test getTimestamp(v1) == testTimestamp
 
-    @test timestamp(f1) == f1.timestamp
+    @test getTimestamp(f1) == f1.timestamp
     testTimestamp = now()
     @test setTimestamp!(f1, testTimestamp) == testTimestamp
-    @test timestamp(f1) == f1.timestamp
+    @test getTimestamp(f1) == f1.timestamp
 
     @test estimates(v1) == v1.estimateDict
     @test estimate(v1, :notfound) == nothing