update deprecated.jl

Author: dehann

src/Deprecated.jl

@@ -101,14 +101,6 @@ end
 
 @deprecate getFactorIds(dfg, regexFilter=nothing; solvable=0) listFactors(dfg, regexFilter, solvable=solvable)
 
-#NOTE too many aliases on PPE
-
-@deprecate getVariablePPEs(v::VariableDataLevel1) getPPEDict(v)
-
-@deprecate getPPEs(vari::VariableDataLevel1) getPPEDict(v)
-
-@deprecate getVariablePPE(args...) getPPE(args...)
-
 
 #TODO doesn't look like this existed
 # @deprecate timestamp(v) getTimestamp(v)

src/DistributedFactorGraphs.jl

@@ -144,6 +144,9 @@ export getPPEDict
 
 # CRUD & SET
 export getPPE,
+       getPPEs,
+       getVariablePPE,
+       getVariablePPEs,
        addPPE!,
        updatePPE!,
        deletePPE!,

src/needsahome.jl

@@ -89,7 +89,7 @@ print(fct::DFGFactor) = @show fct
 
 Display and return to console the user factor identified by tag name.
 """
-printFactor(fgl::AbstractDFG, fsym::Symbol) = print(getFactor(dfg, sym))
+printFactor(dfg::AbstractDFG, sym::Symbol) = print(getFactor(dfg, sym))
 
 """
    $SIGNATURES
@@ -99,11 +99,19 @@ Display the content of `VariableNodeData` to console for a given factor graph an
 Dev Notes
 - TODO split as two show macros between AMP and DFG
 """
-printVariable(fgl::AbstractDFG, vsym::Symbol, solveKey::Symbol=:default) = print(getVariable(dfg, sym))
+printVariable(dfg::AbstractDFG, sym::Symbol, solveKey::Symbol=:default) = print(getVariable(dfg, sym))
 
-print(fgl::AbstractDFG, fsym::Symbol) = isVariable(dfg,fsym) ? printVariable(dfg, fsym) : printFactor(dfg, sym)
+print(dfg::AbstractDFG, sym::Symbol) = isVariable(dfg,sym) ? printVariable(dfg, sym) : printFactor(dfg, sym)
 
 
+#NOT too many aliases on PPE, brought back from deprecated DF
+
+getVariablePPEs(v::VariableDataLevel1) = getPPEDict(v)
+
+getPPEs(vari::VariableDataLevel1) = getPPEDict(v)
+
+getVariablePPE(args...) = getPPE(args...)
+
 ## KEEPING COMMENT, WANT TO BE CONSOLIDATED WITH FUNCTION ABOVE -- KEEPING ONLY ONE FOR MAINTAINABILITY
 ## STILL NEEDS TO BE CONSOLIDATED WITH `DFG._copyIntoGraph`
 # """

test/testBlocks.jl

@@ -468,8 +468,8 @@ function  PPETestBlock!(fg, v1)
     @test deletePPE!(fg, :a, :default) == ppe
 
     #FIXME copied from lower
-    @test @test_deprecated getVariablePPEs(v1) == v1.ppeDict
-    @test_throws KeyError getPPE(v1, :notfound)
+    # @test @test_deprecated getVariablePPEs(v1) == v1.ppeDict
+    @test_throws Union{KeyError,UndefVarError} getPPE(v1, :notfound)
     #TODO
     # @test_deprecated getVariablePPE(v1)