Merge pull request #571 from JuliaRobotics/maint/20Q3/softtypedepr

Deprecate softtype fields, add getManifolds and getDimension interface

Author: Affie

src/Deprecated.jl

@@ -174,3 +174,15 @@ const fetchDataEntryElement = getDataEntryBlob
 const fetchData = getDataEntryBlob
 
 #
+
+## softtype deprections
+function Base.getproperty(x::InferenceVariable, f::Symbol)
+  if f==:dims
+      Base.depwarn("Softtype $(typeof(x)), field dims is deprecated, extend and use `getDims` instead",:getproperty)
+  elseif f==:manifolds
+      Base.depwarn("Softtype $(typeof(x)), field manifolds is deprecated, extend and use `getManifolds` instead",:getproperty)
+  else
+      Base.depwarn("Softtype $(typeof(x)), will be required to be a singleton type in the future and can no longer have fields. *.$f called",:getproperty)
+  end
+  return getfield(x,f)
+end

src/entities/DFGVariable.jl

@@ -4,6 +4,16 @@
 
 abstract type InferenceVariable end
 
+"""
+    $SIGNATURES
+Interface function to return the softtype dimention of an InferenceVariable, extend this function for all Types<:InferenceVariable.
+"""
+function getDimension end
+"""
+    $SIGNATURES
+Interface function to return the softtype manifolds of an InferenceVariable, extend this function for all Types<:InferenceVariable.
+"""
+function getManifolds end
 ##==============================================================================
 ## VariableNodeData
 ##==============================================================================

src/services/CompareUtils.jl

@@ -10,7 +10,7 @@ For now abstract `InferenceVariable`s are considered equal if they are the same
 If your implentation has aditional properties such as `DynPose2` with `ut::Int64` (microsecond time) or support different manifolds
 implement compare if needed.
 =#
-==(a::InferenceVariable,b::InferenceVariable) = typeof(a) == typeof(b) && a.dims == b.dims && a.manifolds == b.manifolds
+# ==(a::InferenceVariable,b::InferenceVariable) = typeof(a) == typeof(b) && a.dims == b.dims && a.manifolds == b.manifolds
 
 ==(a::FactorOperationalMemory, b::FactorOperationalMemory) = typeof(a) == typeof(b)