add dispatch on getPPE

Author: dehann

src/services/DFGVariable.jl

@@ -16,8 +16,8 @@ getPPEMean(fg::AbstractDFG, varlabel::Symbol, solveKey::Symbol=:default) =
 
 "$(SIGNATURES)"
 getPPESuggested(est::AbstractPointParametricEst) = est.suggested
-getPPESuggested(fg::AbstractDFG, varlabel::Symbol, solveKey::Symbol=:default) =
-                getPPE(fg, varlabel, solveKey) |> getPPESuggested
+getPPESuggested(var::DFGVariable, solveKey::Symbol=:default) = getPPE(var, solveKey) |> getPPESuggested
+getPPESuggested(dfg::AbstractDFG, varlabel::Symbol, solveKey::Symbol=:default) = getPPE(getVariable(dfg, varlabel), solveKey)
 
 "$(SIGNATURES)"
 getLastUpdatedTimestamp(est::AbstractPointParametricEst) = est.lastUpdatedTimestamp
@@ -793,14 +793,13 @@ Notes
 - Defaults on keywords `solveKey` and `method`
 
 Related
-getMeanPPE, getMaxPPE, getKDEMean, getKDEFit, getPPEs, getVariablePPEs
+[`getMeanPPE`](@ref), [`getMaxPPE`](@ref), [`updatePPE!`](@ref), getKDEMean, getKDEFit, getPPEs, getVariablePPEs
 """
-function getPPE(dfg::AbstractDFG, variablekey::Symbol, ppekey::Symbol=:default)
-    v = getVariable(dfg, variablekey)
-    !haskey(v.ppeDict, ppekey) && error("PPE key '$ppekey' not found in variable '$variablekey'")
+function getPPE(v::DFGVariable, ppekey::Symbol=:default)
+    !haskey(v.ppeDict, ppekey) && error("PPE key '$ppekey' not found in variable '$(getLabel(v))'")
     return v.ppeDict[ppekey]
 end
-
+getPPE(dfg::AbstractDFG, variablekey::Symbol, ppekey::Symbol=:default) = getPPE(getVariable(dfg, variablekey), ppekey)
 # Not the most efficient call but it at least reuses above (in memory it's probably ok)
 getPPE(dfg::AbstractDFG, sourceVariable::VariableDataLevel1, ppekey::Symbol=:default) = getPPE(dfg, sourceVariable.label, ppekey)
 

test/testBlocks.jl

@@ -598,9 +598,9 @@ function  PPETestBlock!(fg, v1)
     @test_throws ErrorException addPPE!(fg, :a, ppe)
 
     @test listPPEs(fg, :a) == [:default]
-    # Get the data back - note that this is a reference to above.
-    @test getPPE(fg, :a, :default) == ppe
 
+    # Get the data back - note that this is a reference to above.
+    @test getPPE(getVariable(fg, :a), :default) == ppe
     @test getPPE(fg, :a, :default) == ppe
     @test getPPEMean(fg, :a, :default) == ppe.mean
     @test getPPEMax(fg, :a, :default) == ppe.max