Skip to content

Commit cfcfc5e

Browse files
authored
Apply suggestions from code review
1 parent c1836cc commit cfcfc5e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/CloudGraphsDFG/services/CloudGraphsDFG.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ function getFactor(dfg::CloudGraphsDFG, label::Union{Symbol, String})
270270
length(result.results[1]["data"][1]["row"]) != 1 && error("Cannot get factor '$label'")
271271
props = result.results[1]["data"][1]["row"][1]
272272

273-
# NOTE: Until we address #590, base64 decode the data to ensure robustness
273+
# NOTE: Until we address #590, base64 decode the data to ensure robustness, #833
274274
props["data"] = String(base64decode(props["data"]))
275275

276276
return rebuildFactorMetadata!(dfg, unpackFactor(dfg, props))

src/services/Serialization.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ function _packSolverData(
301301
packed = convert( PackedFunctionNodeData{packtype}, getSolverData(f) )
302302
packedJson = JSON2.write(packed)
303303
if base64Encode
304+
# 833
304305
packedJson = base64encode(packedJson)
305306
end
306307
return packedJson

0 commit comments

Comments
 (0)