Merge pull request #467 from JuliaRobotics/hotfix/20Q2/serialModule#462

Remove get/setSerializationModule and always use Main

Author: Affie

src/CloudGraphsDFG/services/CloudGraphsDFG.jl

@@ -38,11 +38,6 @@ function setDescription!(dfg::CloudGraphsDFG, description::String)
     return getDescription(dfg)
 end
 
-function getSerializationModule(dfg::CloudGraphsDFG)::Module where G <: AbstractDFG
-    # TODO: If we need to specialize this for RoME etc, here is where we'll change it.
-    return Main
-end
-
 ##==============================================================================
 ## User/Robot/Session Data CRUD
 ##==============================================================================

src/DistributedFactorGraphs.jl

@@ -207,7 +207,6 @@ export hasTags, hasTagsNeighbors
 export findClosestTimestamp, findVariableNearTimestamp
 
 # Serialization
-export setSerializationModule!, getSerializationModule
 export packVariable, unpackVariable, packFactor, unpackFactor
 
 # File import and export

src/services/Serialization.jl

@@ -176,42 +176,14 @@ end
 ## Serialization
 ##==============================================================================
 
-"""
-    $(SIGNATURES)
-
-Deserialization of IncrementalInference objects require discovery of foreign types.
-
-Example:
-
-Template to tunnel types from a user module:
-```julia
-# or more generic solution -- will always try Main if available
-IIF.setSerializationNamespace!(Main)
-
-# or a specific package such as RoME if you import all variable and factor types into a specific module.
-using RoME
-IIF.setSerializationNamespace!(RoME)
-```
-"""
-function setSerializationModule!(dfg::G, mod::Module)::Nothing where G <: AbstractDFG
-    @warn "Setting serialization module from AbstractDFG - override this in the '$(typeof(dfg)) structure! This is being ignored."
-end
-
-function getSerializationModule(dfg::G)::Module where G <: AbstractDFG
-    @warn "Retrieving serialization module from AbstractDFG - override this in the '$(typeof(dfg)) structure! This is returning Main"
-    return Main
-end
-
 """
   $(SIGNATURES)
 Get a type from the serialization module inside DFG.
 """
 function getTypeFromSerializationModule(dfg::G, moduleType::Symbol) where G <: AbstractDFG
     st = nothing
-    mainmod = getSerializationModule(dfg)
-    mainmod == nothing && error("Serialization module is null - please call setSerializationNamespace!(\"Main\" => Main) in your main program.")
     try
-        st = getfield(mainmod, Symbol(moduleType))
+        st = getfield(Main, Symbol(moduleType))
     catch ex
         @error "Unable to deserialize soft type $(d.softtype)"
         io = IOBuffer()