imporve Agent/Graph Blobentry test

Author: Affie

src/DataBlobs/entities/BlobEntry.jl

@@ -113,23 +113,6 @@ function Base.getproperty(x::Blobentry, f::Symbol)
     end
 end
 
-function Base.setproperty!(x::Blobentry, f::Symbol, val)
-    if f == :blobId
-        @warn "Blobentry field :blobId has been renamed to :blobid"
-        setfield!(x, :blobid, val)
-    elseif f == :mimeType
-        @warn "Blobentry field :mimeType has been renamed to :mimetype"
-        setfield!(x, :mimetype, val)
-    elseif f == :_version
-        @warn "Blobentry field :_version has been renamed to :version"
-        setfield!(x, :version, val)
-    elseif f in [:id, :createdTimestamp, :lastUpdatedTimestamp, :hash]
-        error("Blobentry field $f has been deprecated")
-    else
-        setfield!(x, f, val)
-    end
-end
-
 const Blobentries = OrderedDict{Symbol, Blobentry}
 
 function StructUtils.lower(entries::Blobentries)

src/GraphsDFG/FactorGraphs/FactorGraphs.jl

@@ -95,8 +95,7 @@ has_vertex(g::FactorGraph, x...) = has_vertex(g.graph, x...)
 inneighbors(g::FactorGraph, v::Integer) = inneighbors(g.graph, v)
 outneighbors(g::FactorGraph, v::Integer) = fadj(g.graph, v)
 
-is_directed(::Type{FactorGraph}) = false
-is_directed(::Type{FactorGraph{T, V, F}}) where {T, V, F} = false
+is_directed(::Type{<:FactorGraph}) = false
 is_directed(g::FactorGraph) = false
 
 Base.zero(g::FactorGraph{T, V, F}) where {T, V, F} = FactorGraph{T, V, F}(0, 0)

test/testBlocks.jl

@@ -184,6 +184,10 @@ function GraphAgentBlobentries!(fg::AbstractDFG)
     @test hasAgentBlobentry(fg, :key1) == false
     @test_throws DFG.LabelNotFoundError getAgentBlobentry(fg, :key1)
     @test_throws DFG.LabelNotFoundError deleteAgentBlobentry!(fg, :key1)
+    @test addAgentBlobentries!(fg, [be]) == [be]
+    @test deleteAgentBlobentries!(fg, [:key1]) == 1
+    @test mergeAgentBlobentries!(fg, [be]) == 1
+    @test deleteAgentBlobentries!(fg, [:key1]) == 1
 
     # Graph Blob Entries
     ae = addGraphBlobentry!(fg, be)
@@ -199,6 +203,10 @@ function GraphAgentBlobentries!(fg::AbstractDFG)
     @test hasGraphBlobentry(fg, :key1) == false
     @test_throws DFG.LabelNotFoundError getGraphBlobentry(fg, :key1)
     @test_throws DFG.LabelNotFoundError deleteGraphBlobentry!(fg, :key1)
+    @test addGraphBlobentries!(fg, [be]) == [be]
+    @test deleteGraphBlobentries!(fg, [:key1]) == 1
+    @test mergeGraphBlobentries!(fg, [be]) == 1
+    @test deleteGraphBlobentries!(fg, [:key1]) == 1
 
     be2 = Blobentry(; blobid = uuid4(), label = :key2, blobstore = :b)